linux-kernel - Re: [PATCH v1] docs: networking: can: change bcm_msg_head frames member to support flexible array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7c707b7-61e1-4c40-8708-f3331da96d34@hartkopp.net>
Date: Thu, 4 Sep 2025 08:25:32 +0200
From: Oliver Hartkopp <socketcan@...tkopp.net>
To: Alex Tran <alex.t.tran@...il.com>
Cc: mkl@...gutronix.de, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 linux-can@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] docs: networking: can: change bcm_msg_head frames
 member to support flexible array



On 04.09.25 05:17, Alex Tran wrote:
> The documentation of the 'bcm_msg_head' struct does not match how
> it is defined in 'bcm.h'. Changed the frames member to a flexible array,
> matching the definition in the header file.
> 
> See commit 94dfc73e7cf4 ("treewide: uapi: Replace zero-length arrays with
> flexible-array members")
> 
> Bug 217783 <https://bugzilla.kernel.org/show_bug.cgi?id=217783>
> 
> Signed-off-by: Alex Tran <alex.t.tran@...il.com>

Acked-by: Oliver Hartkopp <socketcan@...tkopp.net>

Thanks Alex!

> ---
>   Documentation/networking/can.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/networking/can.rst b/Documentation/networking/can.rst
> index bc1b585355f7..7650c4b5be5f 100644
> --- a/Documentation/networking/can.rst
> +++ b/Documentation/networking/can.rst
> @@ -742,7 +742,7 @@ The broadcast manager sends responses to user space in the same form:
>               struct timeval ival1, ival2;    /* count and subsequent interval */
>               canid_t can_id;                 /* unique can_id for task */
>               __u32 nframes;                  /* number of can_frames following */
> -            struct can_frame frames[0];
> +            struct can_frame frames[];
>       };
>   
>   The aligned payload 'frames' uses the same basic CAN frame structure defined