linux-kernel - Re: [PATCH v3 1/3] dt-bindings: ata: eswin: Document for EIC7700 SoC ahci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8489c13b-6810-480c-9894-bb5c80cfbde0@kernel.org>
Date: Thu, 4 Sep 2025 09:10:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yulin Lu <luyulin@...incomputing.com>, dlemoal@...nel.org,
 cassel@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 linux-ide@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, vkoul@...nel.org, kishon@...nel.org,
 linux-phy@...ts.infradead.org
Cc: ningyu@...incomputing.com, zhengyu@...incomputing.com,
 linmin@...incomputing.com, huangyifeng@...incomputing.com,
 fenglin@...incomputing.com, lianghujun@...incomputing.com
Subject: Re: [PATCH v3 1/3] dt-bindings: ata: eswin: Document for EIC7700 SoC
 ahci

On 04/09/2025 08:37, Yulin Lu wrote:
> Add document for the SATA AHCI controller on the EIC7700 SoC platform,

Subject: drop "for", wrong grammar. "Document" is a verb.

> including descriptions of its hardware configurations.
> 
> Signed-off-by: Yulin Lu <luyulin@...incomputing.com>


...

> +
> +maintainers:
> +  - Yulin Lu <luyulin@...incomputing.com>
> +  - Huan He <hehuan1@...incomputing.com>
> +
> +description:
> +  This document defines device tree bindings for the Synopsys DWC

Describe the hardware, not the document. Entire line is completely
redundant.

> +  implementation of the AHCI SATA controller found in Eswin's
> +  Eic7700 SoC platform.
> +



...

> +  clock-names:
> +    items:
> +      - const: pclk
> +      - const: aclk
> +
> +  resets:
> +    maxItems: 1
> +
> +  reset-names:
> +    const: arst
> +
> +  ports-implemented:
> +    const: 1

I do not see how you addressed request about firmware. Nothing changed
here, no explanation in the commit msg.


Best regards,
Krzysztof