linux-kernel - Re: [PATCH v2 2/3] thermal: gov_step_wise: Clarify cooling logic description comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f0c03aa-bdb5-4a30-b81c-59e0e68313be@arm.com>
Date: Thu, 4 Sep 2025 08:22:31 +0100
From: Lukasz Luba <lukasz.luba@....com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v2 2/3] thermal: gov_step_wise: Clarify cooling logic
 description comment



On 8/25/25 14:28, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> The cooling logic description comment next to the get_target_state()
> definition is slightly ambiguous in what it means by "lower cooling
> state", so clarify that by replacing the ambuguous phrase with "the
> minimum applicable cooling state".
> 
> No functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>   drivers/thermal/gov_step_wise.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/drivers/thermal/gov_step_wise.c
> +++ b/drivers/thermal/gov_step_wise.c
> @@ -23,8 +23,8 @@
>    *    b. if the trend is THERMAL_TREND_DROPPING, do nothing
>    * If the temperature is lower than a trip point,
>    *    a. if the trend is THERMAL_TREND_RAISING, do nothing
> - *    b. if the trend is THERMAL_TREND_DROPPING, use lower cooling
> - *       state for this trip point, if the cooling state already
> + *    b. if the trend is THERMAL_TREND_DROPPING, use the minimum applicable
> + *       cooling state for this trip point, or if the cooling state already
>    *       equals lower limit, deactivate the thermal instance
>    */
>   static unsigned long get_target_state(struct thermal_instance *instance,
> 
> 
> 

Reviewed-by: Lukasz Luba <lukasz.luba@....com>