linux-kernel - Re: [PATCH v4 6/9] dt-bindings: clock: nxp,imx95-blk-ctl: Add ldb child node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250904-misty-mini-buzzard-af2aec@kuoka>
Date: Thu, 4 Sep 2025 09:27:31 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Laurentiu Palcu <laurentiu.palcu@....nxp.com>
Cc: imx@...ts.linux.dev, Abel Vesa <abelvesa@...nel.org>, 
	Peng Fan <peng.fan@....com>, Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Frank Li <frank.li@....com>, 
	linux-clk@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 6/9] dt-bindings: clock: nxp,imx95-blk-ctl: Add ldb
 child node

On Wed, Sep 03, 2025 at 03:33:24PM +0300, Laurentiu Palcu wrote:
> Since the BLK CTL registers, like the LVDS CSR, can be used to control the
> LVDS Display Bridge controllers, add 'ldb' child node to handle
> these use cases.
> 
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@....nxp.com>
> ---
>  .../bindings/clock/nxp,imx95-blk-ctl.yaml     | 24 ++++++++++++++++++-
>  1 file changed, 23 insertions(+), 1 deletion(-)

Nothing in the changelog explains this patch.

What happened with entire previous review?

> 
> diff --git a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> index 27403b4c52d62..f83d96701bb04 100644
> --- a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> +++ b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> @@ -39,6 +39,28 @@ properties:
>        ID in its "clocks" phandle cell. See
>        include/dt-bindings/clock/nxp,imx95-clock.h
>  
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        const: nxp,imx94-lvds-csr
> +then:
> +  properties:
> +    "#address-cells":
> +      const: 1
> +
> +    "#size-cells":
> +      const: 1
> +
> +  patternProperties:
> +    "^ldb@[0-9a-f]+$":

No, don't define nodes in if:then:. Where did you get this syntax from?

> +      type: object
> +      $ref: /schemas/display/bridge/fsl,ldb.yaml#
> +
> +  required:
> +    - '#address-cells'
> +    - '#size-cells'
> +
>  required:
>    - compatible
>    - reg
> @@ -46,7 +68,7 @@ required:
>    - power-domains
>    - clocks
>  
> -additionalProperties: false
> +unevaluatedProperties: false

NAK, so schema warned you above syntax is wrong and you decided to
silence the warning with this hack, right?

Best regards,
Krzysztof