[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a7dfd3da-fb55-411a-8410-062931c97e3d@arm.com>
Date: Thu, 4 Sep 2025 08:45:11 +0100
From: Lukasz Luba <lukasz.luba@....com>
To: Osama Abdelkader <osama.abdelkader@...il.com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
rafael@...nel.org, daniel.lezcano@...aro.org, rui.zhang@...el.com
Subject: Re: [PATCH v2] thermal: hwmon: replace deprecated strcpy() with
strscpy()
On 9/3/25 20:20, Osama Abdelkader wrote:
> strcpy() is deprecated, use strscpy() instead for consistency with thermal
> subsystem since this is the only strcpy there.
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@...il.com>
> ---
> v2:
> Improve the commit msg: add that this is the only strcpy left in thermal subsystem
> ---
> drivers/thermal/thermal_hwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
> index 0ecccd4d8556..64cc3ab949fe 100644
> --- a/drivers/thermal/thermal_hwmon.c
> +++ b/drivers/thermal/thermal_hwmon.c
> @@ -96,7 +96,7 @@ thermal_hwmon_lookup_by_type(const struct thermal_zone_device *tz)
>
> mutex_lock(&thermal_hwmon_list_lock);
> list_for_each_entry(hwmon, &thermal_hwmon_list, node) {
> - strcpy(type, tz->type);
> + strscpy(type, tz->type);
> strreplace(type, '-', '_');
> if (!strcmp(hwmon->type, type)) {
> mutex_unlock(&thermal_hwmon_list_lock);
LGTM, that was indeed the single occurrence in thermal sub-system.
Thanks!
Reviewed-by: Lukasz Luba <lukasz.luba@....com>
Powered by blists - more mailing lists