Message-ID: <CAFQXuNZpLBP3=MGmRRpwJu43ZtkNhrTzh8kOwFgKy20rqFiG7Q@mail.gmail.com>
Date: Thu, 4 Sep 2025 16:08:30 +0800
From: 杨孙运 <yangsunyun1993@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: syyang <syyang@...tium.com>, robh@...nel.org, Laurent.pinchart@...asonboard.com, 
	andrzej.hajda@...el.com, conor+dt@...nel.org, devicetree@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, jernej.skrabec@...il.com, jonas@...boo.se, 
	krzk+dt@...nel.org, linux-kernel@...r.kernel.org, neil.armstrong@...aro.org, 
	rfoss@...nel.org
Subject: Re: [PATCH v2 1/2] This patch adds a new device tree binding documentation.

Krzysztof Kozlowski <krzk@...nel.org> 于2025年9月4日周四 13:49写道：
>
> On 04/09/2025 04:25, syyang wrote:
> > Fix device tree binding validation errors reported by Rob Herring.
> >
> > v2:
>
> That's not the place where you put changelog.
>
I'm currently learning what to do. Thank you

> > - Fixed $id field to match actual filename (lontium,lt9611c.yaml)
> > - build pass
> >
> > Thanks to Rob Herring for the review and feedback.
>
> Please carefully read submitting patches.
>
I'm currently learning what to do. Thank you

> Do not attach (thread) your patchsets to some other threads (unrelated
> or older versions). This buries them deep in the mailbox and might
> interfere with applying entire sets. See also:
> https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
I'm currently learning what to do. Thank you.

> >
> > Signed-off-by: syyang <syyang@...tium.com>
> > ---
> >  .../display/bridge/lontium,lt9611c.yaml       | 121 ++++++++++++++++++
> >  1 file changed, 121 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/bridge/lontium,lt9611c.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611c.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611c.yaml
> > new file mode 100644
> > index 000000000000..712644da4f1d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611c.yaml
> > @@ -0,0 +1,121 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/bridge/lontium,lt9611c.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Lontium LT9611C 2 Port MIPI to HDMI Bridge
> > +
> > +maintainers:
> > +  - Rob Herring <robh@...nel.org>
>
> No, how so?
>
I will change it to the email address I use when working at the
company.  (syyang@...tium.com)

> > +
> > +description: |
>
> Do not need '|' unless you need to preserve formatting.
>
Both lontium,lt9211.yaml and lontium,lt9611.yaml use "|", so please
confirm if they need to be removed.

> > +  The LT9611C are bridge devices which convert DSI to HDMI
>
> Why this cannot be added to lt9611 binding? Commit msg should clearly
> answer that.
>
The lt9611 and lt9611c are chips of different specifications, and
their related parameters are different.
The VDD-supply of lt9611c is 1.2V; the vdd-supply of lt9611uxc is also
1.2V, while the vdd-supply of lt9611 is 1.8V.
Now lt9611 and lt9611uxc are connected together. I'm not sure if this
is a problem.
If this lt9611c can also be bound to lt9611, and if you think it's
okay, then I have no problem.

> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - lontium,lt9611c
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  "#sound-dai-cells":
>
> Missing dai-common ref.
>
I don't understand .   I referred to:
Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml

> > +    const: 0
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  reset-gpios:
> > +    maxItems: 1
> > +    description: GPIO connected to active high RESET pin.
> > +
> > +  vdd-supply:
> > +    description: Regulator for 1.2V MIPI phy power.
> > +
> > +  vcc-supply:
> > +    description: Regulator for 3.3V IO power.
> > +
> > +  ports:
> > +    $ref: /schemas/graph.yaml#/properties/ports
> > +
> > +    properties:
> > +      port@0:
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +        description:
> > +          Primary MIPI port-1 for MIPI input
> > +
> > +      port@1:
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +        description:
> > +          Additional MIPI port-2 for MIPI input, used in combination
> > +          with primary MIPI port-1 to drive higher resolution displays
> > +
> > +      port@2:
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +        description:
> > +          HDMI port for HDMI output
> > +
> > +    required:
> > +      - port@0
> > +      - port@2
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - vdd-supply
> > +  - vcc-supply
> > +  - ports
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    i2c10 {
> > +      #address-cells = <1>;
> > +      #size-cells = <0>;
> > +
> > +      hdmi-bridge@41 {
> > +        compatible = "lontium,lt9611c";
> > +        reg = <0x41>;
> > +        #sound-dai-cells = <0>;
> > +        interrupts-extended = <&pio 128 GPIO_ACTIVE_HIGH>;
> > +        reset-gpios = <&pio 127 GPIO_ACTIVE_HIGH>;
> > +        vdd-supply = <&lt9611_1v2>;
> > +        vcc-supply = <&lt9611_3v3>;
> > +        status = "okay";
>
> Nope, drop.
>
remove  status = "okay"  ?
>
>
> Best regards,
> Krzysztof

Powered by blists - more mailing lists