linux-kernel - Re: [PATCH 1/6] crypto: curve25519

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWrJmj9jHJp5CEtzBJk6jiN81ZwmTAogc07U_P9KgyEjA@mail.gmail.com>
Date: Thu, 4 Sep 2025 10:10:33 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Ard Biesheuvel <ardb@...nel.org>, "Jason A . Donenfeld" <Jason@...c4.com>, Zhiqi Song <songzhiqi1@...wei.com>, 
	Longfang Liu <liulongfang@...wei.com>, x86@...nel.org, 
	linux-arm-kernel@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 1/6] crypto: curve25519 - Remove kpp support

On Mon, 1 Sept 2025 at 22:29, Eric Biggers <ebiggers@...nel.org> wrote:
> Currently, Curve25519 has both a library API and a crypto_kpp API.
> However, the crypto_kpp API to Curve25519 has no users outside
> crypto/testmgr.c.  I.e., no non-test code ever passes "curve25519" to
> crypto_alloc_kpp().  And the crypto/testmgr.c test coverage for
> Curve25519 isn't particularly useful either, since it just runs the same
> list of test vectors that curve25519-selftest uses.
>
> Therefore, all the crypto_kpp support for Curve25519 is unnecessary.
>
> Remove it.  We'll instead focus on the Curve25519 library API, which is
> the API that is actually being used.  Curve25519 remains fully supported
> for in-kernel users via the library API (crypto/curve25519.h).
>
> Signed-off-by: Eric Biggers <ebiggers@...nel.org>

>  arch/m68k/configs/amiga_defconfig             |    1 -
>  arch/m68k/configs/apollo_defconfig            |    1 -
>  arch/m68k/configs/atari_defconfig             |    1 -
>  arch/m68k/configs/bvme6000_defconfig          |    1 -
>  arch/m68k/configs/hp300_defconfig             |    1 -
>  arch/m68k/configs/mac_defconfig               |    1 -
>  arch/m68k/configs/multi_defconfig             |    1 -
>  arch/m68k/configs/mvme147_defconfig           |    1 -
>  arch/m68k/configs/mvme16x_defconfig           |    1 -
>  arch/m68k/configs/q40_defconfig               |    1 -
>  arch/m68k/configs/sun3_defconfig              |    1 -
>  arch/m68k/configs/sun3x_defconfig             |    1 -

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org> # m68k
(although this would be handled during the regular defconfig refresh anyway)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds