[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250904102405.3109bfa6.michal.pecio@gmail.com>
Date: Thu, 4 Sep 2025 10:24:05 +0200
From: Michal Pecio <michal.pecio@...il.com>
To: Ricardo Ribalda <ribalda@...omium.org>, Laurent Pinchart
<laurent.pinchart@...asonboard.com>, Hans de Goede <hansg@...nel.org>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: uvcvideo: Shorten the transfer size non
compliance message
On Thu, 4 Sep 2025 09:20:31 +0200, Ricardo Ribalda wrote:
> Hi Michal
>
> I like the new writing :)
>
> On Thu, 4 Sept 2025 at 08:14, Michal Pecio <michal.pecio@...il.com> wrote:
> >
> > This message is much longer than others and doesn't fit even in a 160
> > column window when printed, despite providing little real information.
> >
> > Also replace 'transmission' with 'transfer' because that's the actual
> > name and 'max packet' with 'limit' because it isn't same thing with
> > isochronus endpoints. Remove cryptic abbreviations like 'ep'.
> >
> Reviewed-by: Ricardo Ribalda <ribalda@...omium.org>
Thank you.
On second thought, I'm not sure if those brackets look good here:
[ 2410.688715] uvcvideo 11-1:1.1: UVC non compliance: Reducing max payload transfer size (32764) to fit endpoint limit (20480).
but I sent the patch already. If you think it would be better without
them, please feel free to tweak the patch or ask for v2. If not, meh.
Regards,
Michal
Powered by blists - more mailing lists