linux-kernel - Re: [RFC PATCH 16/17] verification/rvgen: Add support for per-obj monitors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250904085805.X1LXKplC@linutronix.de>
Date: Thu, 4 Sep 2025 10:58:05 +0200
From: Nam Cao <namcao@...utronix.de>
To: Gabriele Monaco <gmonaco@...hat.com>
Cc: linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
	linux-trace-kernel@...r.kernel.org,
	Tomas Glozar <tglozar@...hat.com>, Juri Lelli <jlelli@...hat.com>,
	Clark Williams <williams@...hat.com>,
	John Kacur <jkacur@...hat.com>
Subject: Re: [RFC PATCH 16/17] verification/rvgen: Add support for per-obj
 monitors

On Thu, Sep 04, 2025 at 10:39:31AM +0200, Gabriele Monaco wrote:
> Mmh, I see what you mean.
> I wasn't aware of this textwrap, but what immediately comes to mind is
> that we'd end up mixing spaces (python indentation) and tabs (C
> indentation).
>
> While textwrap may handle the case, it doesn't look too readable to me.
> 
> I'd say we can (slowly) transition to using textwrap here but mandate
> having \t for tabs to make them explicit (didn't test).
> 
> What do you think?

Right, I didn't consider the mixing indentation problem.

Using \t isn't much better, it is harder to see how the generated code will
look.

One idea is using something like clang-format
(Documentation/dev-tools/clang-format.rst). It doesn't have to be done in
this series of course, I'm fine leaving this be for now.

Nam