linux-kernel - Re: [PATCH] LoongArch: KVM: remove unused returns.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5bd70387-0dc0-fe66-5c5a-5914dd32d6bc@loongson.cn>
Date: Thu, 4 Sep 2025 16:57:59 +0800
From: Bibo Mao <maobibo@...ngson.cn>
To: Huacai Chen <chenhuacai@...nel.org>, cuitao <cuitao@...inos.cn>
Cc: yangtiezhu@...ngson.cn, kernel@...0n.name, kvm@...r.kernel.org,
 linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev,
 zhaotianrui@...ngson.cn
Subject: Re: [PATCH] LoongArch: KVM: remove unused returns.

On 2025/9/4 下午4:20, Huacai Chen wrote:
> On Thu, Sep 4, 2025 at 4:14 PM cuitao <cuitao@...inos.cn> wrote:
>>
>> Thanks for the review.
>>
>> My initial idea was to remove the switch-case structure.
>> However, after checking the case value KVM_FEATURE_STEAL_TIME,
>> I found there are 13 parallel definitions—and it is unclear when
>> this part of the development will be completed later. Therefore,
>> I temporarily retained the switch-case structure.
>>
>> Now, I have updated the patch according to your suggestion:
>> - Replaced `switch` with `if` since there is only one case.
>> - Removed the redundant semicolon after the block.
>>
>> Please see the updated patch below.
> It has been applied, don't make useless effort.
> https://github.com/chenhuacai/linux/commit/f5d35375a6546bcc5d0993e3a48cdbc3a7217544
I think that it is unnecessary to replace `switch` with `if` here:)

One thing is that the change is big for such thing, and also there may 
be new case condition in future, just maybe.

Regards
Bibo Mao
> 
> Huacai
> 
>>
>> Thanks,
>> Tiezhu