linux-kernel - Re: [PATCH 02/19] dt-bindings: clock: mobileye: rename to eyeq-clk.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250904-warping-literate-myna-f6d633@kuoka>
Date: Thu, 4 Sep 2025 11:24:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Benoît Monin <benoit.monin@...tlin.com>
Cc: Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>, 
	Gregory CLEMENT <gregory.clement@...tlin.com>, Théo Lebrun <theo.lebrun@...tlin.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Philipp Zabel <p.zabel@...gutronix.de>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	linux-mips@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-clk@...r.kernel.org, Tawfik Bayouk <tawfik.bayouk@...ileye.com>, 
	Sari Khoury <sari.khoury@...ileye.com>
Subject: Re: [PATCH 02/19] dt-bindings: clock: mobileye: rename to eyeq-clk.h

On Wed, Sep 03, 2025 at 02:47:09PM +0200, Benoît Monin wrote:
> Rename the header from mobileye,eyeq5-clk.h to mobileye,eyeq-clk.h as
> it covers more SoCs than just the eyeQ5, but also the eyeQ6L and
> eyeQ6H.
> 
> Also changes all includes to point to the renamed header.
> 
> Signed-off-by: Benoît Monin <benoit.monin@...tlin.com>
> ---
>  MAINTAINERS                                                           | 2 +-
>  arch/mips/boot/dts/mobileye/eyeq5.dtsi                                | 2 +-
>  arch/mips/boot/dts/mobileye/eyeq6h.dtsi                               | 2 +-
>  drivers/clk/clk-eyeq.c                                                | 2 +-
>  .../dt-bindings/clock/{mobileye,eyeq5-clk.h => mobileye,eyeq-clk.h}   | 4 ++--

NAK, stop doing such renames.

Look how other well upstreamed SoCs are doing this - you want file per
SoC variant, so you want SEPARATE eyeq7 header.

Best regards,
Krzysztof