linux-kernel - Re: [PATCH 6/9] mm, swap: use the swap table for the swap cache and switch API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21b8a9a7-b737-4ed6-9690-dfe07ee233b5@redhat.com>
Date: Thu, 4 Sep 2025 11:28:22 +0200
From: David Hildenbrand <david@...hat.com>
To: Kairui Song <ryncsn@...il.com>
Cc: linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
 Matthew Wilcox <willy@...radead.org>, Hugh Dickins <hughd@...gle.com>,
 Chris Li <chrisl@...nel.org>, Barry Song <baohua@...nel.org>,
 Baoquan He <bhe@...hat.com>, Nhat Pham <nphamcs@...il.com>,
 Kemeng Shi <shikemeng@...weicloud.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 Ying Huang <ying.huang@...ux.alibaba.com>,
 Johannes Weiner <hannes@...xchg.org>, Yosry Ahmed <yosryahmed@...gle.com>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Zi Yan <ziy@...dia.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/9] mm, swap: use the swap table for the swap cache and
 switch API

>>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
>>> index 2a47cd3bb649..209580d395a1 100644
>>> --- a/mm/huge_memory.c
>>> +++ b/mm/huge_memory.c
>>> @@ -3721,7 +3721,7 @@ static int __folio_split(struct folio *folio, unsigned int new_order,
>>>        /* Prevent deferred_split_scan() touching ->_refcount */
>>>        spin_lock(&ds_queue->split_queue_lock);
>>>        if (folio_ref_freeze(folio, 1 + extra_pins)) {
>>> -             struct address_space *swap_cache = NULL;
>>> +             struct swap_cluster_info *swp_ci = NULL;
>>
>> I'm wondering if we could also perform this change upfront, so we can ...
> 
> This one seems not very doable on itsown since the cluster idea wasn't
> used out side of swap before this patch..

I think there might be a way, but it's not that trivial. Anyhow, long 
story short, try to move as much as you that logically makes sense can 
out of this patch.

-- 
Cheers

David / dhildenb