linux-kernel - Re: [PATCH 1/2] dt-bindings: leds: add generic LED consumer documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdc68c54-a499-4ba6-8788-70c7ea515f2d@kernel.org>
Date: Thu, 4 Sep 2025 11:45:14 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Hans de Goede <hansg@...nel.org>,
 Aleksandrs Vinarskis <alex@...arskis.com>
Cc: robh@...nel.org, bryan.odonoghue@...aro.org, conor+dt@...nel.org,
 devicetree@...r.kernel.org, krzk+dt@...nel.org, lee@...nel.org,
 linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org, pavel@...nel.org
Subject: Re: [PATCH 1/2] dt-bindings: leds: add generic LED consumer
 documentation

On 04/09/2025 09:26, Hans de Goede wrote:
>>>>> +maintainers:
>>>>> +  - Aleksandrs Vinarskis <alex@...arskis.com>
>>>>> +
>>>>> +description:
>>>>> +  Some LED defined in DT are required by other DT consumers, for example
>>>>> +  v4l2 subnode may require privacy or flash LED.
>>>>> +
>>>>> +  Document LED properties that its consumers may define.
>>>>
>>>> We already have the trigger-source binding for "attaching" LEDs to 
>>>> devices. Why does that not work here?
>>>
>>> I have not actually considered this, as the existing privacy-led solution
>>> from the original series is not trigger based. At least one of the reasons
>>> for that is that trigger source can be rather easily altered from user
>>> space, which would've been bad for this use case. If v4l2 acquires control
>>> over the LED it actually removes triggers and disables sysfs on that LED.
>>
>> So does that mean that v4l2 solves the problem of "trigger source can be
>> rather easily altered from user space"?
> 
> Yes, currently the v4l2-core already does:

Thanks, I understand that it solves the problem described in the patch,
so the patch can be dropped.


Best regards,
Krzysztof