linux-kernel - Re: [PATCH] i2c: designware: use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aLlgsLDFvBGA7OZA@smile.fi.intel.com>
Date: Thu, 4 Sep 2025 12:49:36 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Benoît Monin <benoit.monin@...tlin.com>
Cc: Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Jan Dabros <jsd@...ihalf.com>, Andi Shyti <andi.shyti@...nel.org>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>,
	Tawfik Bayouk <tawfik.bayouk@...ileye.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: designware: use dev_err_probe when probing platform
 device

On Thu, Sep 04, 2025 at 12:47:51PM +0300, Andy Shevchenko wrote:
> On Thu, Sep 04, 2025 at 10:59:24AM +0200, Benoît Monin wrote:
> > Add calls to dev_err_probe on error paths that can return -EPROBE_DEFER

Also add () to the function names or macros with parameters, i.e.
dev_err_probe()

> > when probing platform device. Namely when requesting the reset controller,
> > when probing for lock support and when requesting the clocks.
> > 
> > In i2c_dw_probe_master and i2c_dw_probe_slave, called by the platform

i2c_dw_probe_master() and i2c_dw_probe_slave()

> > probe from i2c_dw_probe, replace the call to dev_err by dev_err_probe

i2c_dw_probe()
dev_err() by dev_err_probe()

> > when failing to acquire the IRQ.
> > 
> > PCI device probing already use dev_err_probe.

dev_err_probe()

> What I see here is two patches:
> 1) conversion existing dev_err() to dev_err_probe();
> 2) adding messages to some of the plain return $ERR.
> 
> Can you split with respective justification for each of them?

-- 
With Best Regards,
Andy Shevchenko