linux-kernel - Re: [PATCH v4 4/4] openrisc: Add jump label support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKxVwgdPzbN4kc2rKxpdG7ONf4BxPCpaAsSQncDsyeW=034cpw@mail.gmail.com>
Date: Thu, 4 Sep 2025 18:19:45 +0800
From: Miao Chen <chenmiao.ku@...il.com>
To: Johannes Berg <johannes@...solutions.net>, Linux Kernel <linux-kernel@...r.kernel.org>, 
	Linux OpenRISC <linux-openrisc@...r.kernel.org>
Cc: Jonathan Corbet <corbet@....net>, Jonas Bonn <jonas@...thpole.se>, 
	Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>, Stafford Horne <shorne@...il.com>, 
	Peter Zijlstra <peterz@...radead.org>, Josh Poimboeuf <jpoimboe@...nel.org>, 
	Jason Baron <jbaron@...mai.com>, Steven Rostedt <rostedt@...dmis.org>, 
	Ard Biesheuvel <ardb@...nel.org>, Masahiro Yamada <masahiroy@...nel.org>, 
	Nicolas Schier <nicolas.schier@...ux.dev>, Sahil Siddiq <sahilcdq0@...il.com>, 
	linux-doc@...r.kernel.org
Subject: Re: [PATCH v4 4/4] openrisc: Add jump label support

Thanks for your review, Johannes. You are absolutely right. I will
wait for other people's review comments and then make the changes
altogether.

Johannes Berg <johannes@...solutions.net> 于2025年9月4日周四 18:07写道：
>
> Hi,
>
> So I'm not quite sure why I'm CC'ed, nor do I really care much, but
> since I was idly reading through it anyway ...
>
> > +             if (unlikely(offset < -134217728 || offset > 134217724)) {
> > +                     WARN_ON_ONCE(true);
> > +             }
>
> Seems like that should just be
>
>         WARN_ON_ONCE(offset < -134217728 || offset > 134217724);
>
> since the unlikely is in there already.
>
> > +     if (early_boot_irqs_disabled) {
> > +             copy_to_kernel_nofault(addr, &insn, sizeof(insn));
> > +     } else {
> > +             patch_insn_write(addr, insn);
> > +     }
>
> (and maybe that doesn't need braces)
>
> johannes