linux-kernel - Re: [PATCH 1/2] dt-bindings: iio: afe: current-sense-amplifier: Add io-channel-cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90aa7f8a-9ce1-425d-a988-3c1f9990ec4d@kernel.org>
Date: Thu, 4 Sep 2025 12:44:28 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Primoz Fiser <primoz.fiser@...ik.com>
Cc: Peter Rosin <peda@...ntia.se>, Jonathan Cameron <jic23@...nel.org>,
 David Lechner <dlechner@...libre.com>, Nuno Sa <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 upstream@...ts.phytec.de
Subject: Re: [PATCH 1/2] dt-bindings: iio: afe: current-sense-amplifier: Add
 io-channel-cells

On 04/09/2025 12:15, Primoz Fiser wrote:
> Hi Krzysztof,
> 
> On 4. 09. 25 11:17, Krzysztof Kozlowski wrote:
>> On Wed, Sep 03, 2025 at 01:36:59PM +0200, Primoz Fiser wrote:
>>> The current-sense-amplifier is an IIO provider thus can be referenced by
>>> IIO consumers (via "io-channels" property in consumer device node). Such
>>> provider is required to describe number of cells used in phandle lookup
>>> with "io-channel-cells" property, otherwise the following kernel error
>>> is present:
>>>
>>>    OF: /iio-hwmon: could not get #io-channel-cells for /current-sense
>>
>> Also, how can I reproduce this error? Do you paste here real errors or
>> just some invented ones from some out of tree code (hint: such would not
>> be relevant).
> 
> I get this error if I apply patch #2 without patch #1. See [1] for more 
> details.
Then your warning is not relevant here.

You said in your commit there is a bug, expressed with that warning, so
you make this commit. Turns out there is no bug, so all the reasons for
this commit are gone.

Rephrase the commit msg to describe accurate reasons WHY you are doing
this. Drop non-existing warnings and any misleading fixes tag, since
there is no bug being fixed.
Best regards,
Krzysztof