[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aLrehYcpQcmmuKPR@8bytes.org>
Date: Fri, 5 Sep 2025 14:58:45 +0200
From: Joerg Roedel <joro@...tes.org>
To: Qianfeng Rong <rongqianfeng@...o.com>
Cc: Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>,
iommu@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/omap: Use int type to store negative error codes
On Fri, Aug 29, 2025 at 10:02:19PM +0800, Qianfeng Rong wrote:
> Change the 'ret' variable from u32 to int to store negative error codes
> or zero;
>
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but it's ugly. Additionally, assigning negative error codes to
> unsigned type may trigger a GCC warning when the -Wsign-conversion flag
> is enabled.
>
> No effect on runtime.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> ---
> drivers/iommu/omap-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Powered by blists - more mailing lists