[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b5be0b7d-35e4-43ca-85f6-fa17c139edba@intel.com>
Date: Fri, 5 Sep 2025 15:07:55 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Ivan Vecera <ivecera@...hat.com>
CC: Jiri Pirko <jiri@...nulli.us>, <netdev@...r.kernel.org>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
<horms@...nel.org>, Jonathan Corbet <corbet@....net>, Prathosh Satish
<Prathosh.Satish@...rochip.com>, <linux-doc@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, Michal Schmidt <mschmidt@...hat.com>, "Petr
Oros" <poros@...hat.com>
Subject: Re: [PATCH net-next v4 0/5] dpll: zl3073x: Add support for devlink
flash
On 9/3/25 12:08, Ivan Vecera wrote:
> Add functionality for accessing device hardware registers, loading
> firmware bundles, and accessing the device's internal flash memory,
> and use it to implement the devlink flash functionality.
>
> Patch breakdown:
> Patch1: helpers to access hardware registers
> Patch2: low level functions to access flash memory
> Patch3: support to load firmware bundles
> Patch4: refactoring device initialization and helper functions
> for stopping and resuming device normal operation
> Patch5: devlink .flash_update callback implementation
>
> Changes:
> v4:
> * fixed issues reported by Jakub (see patches' changelogs)
> v3:
> * fixed issues reported by Przemek (see patches' changelogs)
in general you should carry tags added in previous revisions,
especially if there were no big/opposing/controversial changes
anyway, for the series:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> v2:
> * fixed several warnings found by patchwork bot
> * added includes into new .c files
> * fixed typos
> * fixed uninitialized variable
>
> Ivan Vecera (5):
> dpll: zl3073x: Add functions to access hardware registers
> dpll: zl3073x: Add low-level flash functions
> dpll: zl3073x: Add firmware loading functionality
overflow prevention added here looks good
> dpll: zl3073x: Refactor DPLL initialization
> dpll: zl3073x: Implement devlink flash callback
>
> Documentation/networking/devlink/zl3073x.rst | 14 +
> drivers/dpll/zl3073x/Makefile | 2 +-
> drivers/dpll/zl3073x/core.c | 362 +++++++---
> drivers/dpll/zl3073x/core.h | 33 +
> drivers/dpll/zl3073x/devlink.c | 154 ++++-
> drivers/dpll/zl3073x/devlink.h | 3 +
> drivers/dpll/zl3073x/flash.c | 674 +++++++++++++++++++
> drivers/dpll/zl3073x/flash.h | 29 +
> drivers/dpll/zl3073x/fw.c | 419 ++++++++++++
> drivers/dpll/zl3073x/fw.h | 52 ++
> drivers/dpll/zl3073x/regs.h | 51 ++
> 11 files changed, 1702 insertions(+), 91 deletions(-)
> create mode 100644 drivers/dpll/zl3073x/flash.c
> create mode 100644 drivers/dpll/zl3073x/flash.h
> create mode 100644 drivers/dpll/zl3073x/fw.c
> create mode 100644 drivers/dpll/zl3073x/fw.h
>
Powered by blists - more mailing lists