linux-kernel - Re: [PATCH v3 2/2] arm64: dts: qcom: Add Monaco EVK initial board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ow7gdrkissn4npgbua3krdtkexvf47yu57e6luf7bizfvcvbge@33uwiohzlunk>
Date: Fri, 5 Sep 2025 16:41:21 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Swati Agarwal <swati.agarwal@....qualcomm.com>
Cc: Umang Chheda <umang.chheda@....qualcomm.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Richard Cochran <richardcochran@...il.com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Rakesh Kota <rakesh.kota@....qualcomm.com>,
        Nirmesh Kumar Singh <quic_nkumarsi@...cinc.com>,
        Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>,
        Mohd Ayaan Anwar <quic_mohdayaa@...cinc.com>,
        Arun Khannna <quic_arkhanna@...cinc.com>,
        Monish Chunara <quic_mchunara@...cinc.com>,
        Vikash Garodia <quic_vgarodia@...cinc.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: Add Monaco EVK initial board
 support

On Fri, Sep 05, 2025 at 06:54:25PM +0530, Swati Agarwal wrote:
> On Wed, Aug 27, 2025 at 7:13 AM Dmitry Baryshkov
> <dmitry.baryshkov@....qualcomm.com> wrote:
> >
> > On Tue, Aug 26, 2025 at 11:45:06PM +0530, Umang Chheda wrote:
> > > Add initial device tree support for Monaco EVK board, based on
> > > Qualcomm's QCS8300 SoC.
> > >
> > > Monaco EVK is single board supporting these peripherals:
> > >   - Storage: 1 в 128 GB UFS, micro-SD card, EEPROMs for MACs,
> > >     and eMMC.
> > >   - Audio/Video, Camera & Display ports.
> > >   - Connectivity: RJ45 2.5GbE, WLAN/Bluetooth, CAN/CAN-FD.
> > >   - PCIe ports.
> > >   - USB & UART ports.
> > >
> > > On top of Monaco EVK board additional mezzanine boards can be
> > > stacked in future.
> > >
> > > Add support for the following components :
> > >   - GPI (Generic Peripheral Interface) and QUPv3-0/1
> > >     controllers to facilitate DMA and peripheral communication.
> > >   - TCA9534 I/O expander via I2C to provide 8 additional GPIO
> > >     lines for extended I/O functionality.
> > >   - USB1 controller in device mode to support USB peripheral
> > >     operations.
> >
> > Is it actually peripheral-only?
> Hi Dmitry,
> 
> HW supports OTG mode as well on the USB0 port but for enabling OTG
> mode , it requires two things, one is role switch support and another
> is VBUS supply on/off support. Both will be taken care of by Type-C
> manager HD3SS3220. Currently, VBUS enablement support is not present
> in the driver. Once that support is added, I will add OTG support for
> the USB0 port, until then we would like to keep it in peripheral mode
> for ADB support.

Add comment to the DT file, please.

> 
> This is the same change which was discussed for lemans-evk [1] applies
> for monaco-evk as well.
> 
> [1] https://lore.kernel.org/linux-arm-msm/d6816cc6-c69e-4746-932e-8b030ca17245@oss.qualcomm.com/
> 
> Regards,
> Swati
> >
> > >   - Remoteproc subsystems for supported DSPs such as Audio DSP,
> > >     Compute DSP and Generic DSP, along with their corresponding
> > >     firmware.
> > >   - Configure nvmem-layout on the I2C EEPROM to store data for Ethernet
> > >     and other consumers.
> > >   - QCA8081 2.5G Ethernet PHY on port-0 and expose the
> > >     Ethernet MAC address via nvmem for network configuration.
> > >     It depends on CONFIG_QCA808X_PHY to use QCA8081 PHY.
> > >   - Support for the Iris video decoder, including the required
> > >     firmware, to enable video decoding capabilities.
> >
> > I don't see firmware being declared here.
> >
> > >
> > > Co-developed-by: Rakesh Kota <rakesh.kota@....qualcomm.com>
> > > Signed-off-by: Rakesh Kota <rakesh.kota@....qualcomm.com>
> > > Co-developed-by: Nirmesh Kumar Singh <quic_nkumarsi@...cinc.com>
> > > Signed-off-by: Nirmesh Kumar Singh <quic_nkumarsi@...cinc.com>
> > > Co-developed-by: Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>
> > > Signed-off-by: Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>
> > > Co-developed-by: Mohd Ayaan Anwar <quic_mohdayaa@...cinc.com>
> > > Signed-off-by: Mohd Ayaan Anwar <quic_mohdayaa@...cinc.com>
> > > Co-developed-by: Arun Khannna <quic_arkhanna@...cinc.com>
> > > Signed-off-by: Arun Khannna <quic_arkhanna@...cinc.com>
> > > Co-developed-by: Monish Chunara <quic_mchunara@...cinc.com>
> > > Signed-off-by: Monish Chunara <quic_mchunara@...cinc.com>
> > > Co-developed-by: Vikash Garodia <quic_vgarodia@...cinc.com>
> > > Signed-off-by: Vikash Garodia <quic_vgarodia@...cinc.com>
> > > Co-developed-by: Swati Agarwal <swati.agarwal@....qualcomm.com>
> > > Signed-off-by: Swati Agarwal <swati.agarwal@....qualcomm.com>
> > > Signed-off-by: Umang Chheda <umang.chheda@....qualcomm.com>
> > > ---
> > >  arch/arm64/boot/dts/qcom/Makefile       |   1 +
> > >  arch/arm64/boot/dts/qcom/monaco-evk.dts | 463 ++++++++++++++++++++++++
> > >  2 files changed, 464 insertions(+)
> > >  create mode 100644 arch/arm64/boot/dts/qcom/monaco-evk.dts
> > >
> >
> > --
> > With best wishes
> > Dmitry

-- 
With best wishes
Dmitry