[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202509052149.ChcoGfkh-lkp@intel.com>
Date: Fri, 5 Sep 2025 22:11:58 +0800
From: kernel test robot <lkp@...el.com>
To: alistair23@...il.com, chuck.lever@...cle.com, hare@...nel.org,
kernel-tls-handshake@...ts.linux.dev, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
linux-nvme@...ts.infradead.org, linux-nfs@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, kbusch@...nel.org, axboe@...nel.dk,
hch@....de, sagi@...mberg.me, kch@...dia.com, alistair23@...il.com,
Alistair Francis <alistair.francis@....com>
Subject: Re: [PATCH v2 2/7] net/handshake: Make handshake_req_cancel public
Hi,
kernel test robot noticed the following build errors:
[auto build test ERROR on trondmy-nfs/linux-next]
[also build test ERROR on net/main net-next/main linus/master linux-nvme/for-next v6.17-rc4 next-20250905]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/alistair23-gmail-com/net-handshake-Store-the-key-serial-number-on-completion/20250905-105201
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
patch link: https://lore.kernel.org/r/20250905024659.811386-3-alistair.francis%40wdc.com
patch subject: [PATCH v2 2/7] net/handshake: Make handshake_req_cancel public
config: x86_64-randconfig-001-20250905 (https://download.01.org/0day-ci/archive/20250905/202509052149.ChcoGfkh-lkp@intel.com/config)
compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250905/202509052149.ChcoGfkh-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509052149.ChcoGfkh-lkp@intel.com/
All errors (new ones prefixed by >>):
net/handshake/handshake-test.c: In function 'handshake_req_submit_test4':
>> net/handshake/handshake-test.c:237:9: error: implicit declaration of function 'handshake_req_cancel'; did you mean 'handshake_req_next'? [-Werror=implicit-function-declaration]
237 | handshake_req_cancel(sock->sk);
| ^~~~~~~~~~~~~~~~~~~~
| handshake_req_next
cc1: some warnings being treated as errors
vim +237 net/handshake/handshake-test.c
88232ec1ec5ecf Chuck Lever 2023-04-17 207
88232ec1ec5ecf Chuck Lever 2023-04-17 208 static void handshake_req_submit_test4(struct kunit *test)
88232ec1ec5ecf Chuck Lever 2023-04-17 209 {
88232ec1ec5ecf Chuck Lever 2023-04-17 210 struct handshake_req *req, *result;
88232ec1ec5ecf Chuck Lever 2023-04-17 211 struct socket *sock;
18c40a1cc1d990 Chuck Lever 2023-05-19 212 struct file *filp;
88232ec1ec5ecf Chuck Lever 2023-04-17 213 int err;
88232ec1ec5ecf Chuck Lever 2023-04-17 214
88232ec1ec5ecf Chuck Lever 2023-04-17 215 /* Arrange */
88232ec1ec5ecf Chuck Lever 2023-04-17 216 req = handshake_req_alloc(&handshake_req_alloc_proto_good, GFP_KERNEL);
88232ec1ec5ecf Chuck Lever 2023-04-17 217 KUNIT_ASSERT_NOT_NULL(test, req);
88232ec1ec5ecf Chuck Lever 2023-04-17 218
88232ec1ec5ecf Chuck Lever 2023-04-17 219 err = __sock_create(&init_net, PF_INET, SOCK_STREAM, IPPROTO_TCP,
88232ec1ec5ecf Chuck Lever 2023-04-17 220 &sock, 1);
88232ec1ec5ecf Chuck Lever 2023-04-17 221 KUNIT_ASSERT_EQ(test, err, 0);
18c40a1cc1d990 Chuck Lever 2023-05-19 222 filp = sock_alloc_file(sock, O_NONBLOCK, NULL);
18c40a1cc1d990 Chuck Lever 2023-05-19 223 KUNIT_ASSERT_NOT_ERR_OR_NULL(test, filp);
88232ec1ec5ecf Chuck Lever 2023-04-17 224 KUNIT_ASSERT_NOT_NULL(test, sock->sk);
18c40a1cc1d990 Chuck Lever 2023-05-19 225 sock->file = filp;
88232ec1ec5ecf Chuck Lever 2023-04-17 226
88232ec1ec5ecf Chuck Lever 2023-04-17 227 err = handshake_req_submit(sock, req, GFP_KERNEL);
88232ec1ec5ecf Chuck Lever 2023-04-17 228 KUNIT_ASSERT_EQ(test, err, 0);
88232ec1ec5ecf Chuck Lever 2023-04-17 229
88232ec1ec5ecf Chuck Lever 2023-04-17 230 /* Act */
88232ec1ec5ecf Chuck Lever 2023-04-17 231 result = handshake_req_hash_lookup(sock->sk);
88232ec1ec5ecf Chuck Lever 2023-04-17 232
88232ec1ec5ecf Chuck Lever 2023-04-17 233 /* Assert */
88232ec1ec5ecf Chuck Lever 2023-04-17 234 KUNIT_EXPECT_NOT_NULL(test, result);
88232ec1ec5ecf Chuck Lever 2023-04-17 235 KUNIT_EXPECT_PTR_EQ(test, req, result);
88232ec1ec5ecf Chuck Lever 2023-04-17 236
88232ec1ec5ecf Chuck Lever 2023-04-17 @237 handshake_req_cancel(sock->sk);
4a0f07d71b0483 Jinjie Ruan 2023-09-19 238 fput(filp);
88232ec1ec5ecf Chuck Lever 2023-04-17 239 }
88232ec1ec5ecf Chuck Lever 2023-04-17 240
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists