linux-kernel - Re: [PATCH 1/1] dt-bindings: rtc: pcf85063: remove quartz-load-femtofarads restriction for nxp,pcf85063

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLryTJZzKwI5f4oQ@lizhi-Precision-Tower-5810>
Date: Fri, 5 Sep 2025 10:23:08 -0400
From: Frank Li <Frank.li@....com>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Alexander Stein <alexander.stein@...tq-group.com>,
	"open list:REAL TIME CLOCK (RTC) SUBSYSTEM" <linux-rtc@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: rtc: pcf85063: remove
 quartz-load-femtofarads restriction for nxp,pcf85063

On Fri, Sep 05, 2025 at 09:18:32AM +0200, Alexandre Belloni wrote:
> On 03/09/2025 15:11:27-0400, Frank Li wrote:
> > Original TXT binding doc have not limitition about quartz-load-femtofarads,
> > which only allow 7000 for nxp,pcf85063.
>
> The only valid values are 7000 and 12500, wouldn't it be better to
> improve the limitation rather than removing it?

There are already have such restriction in top

  quartz-load-femtofarads:
    description:
      The capacitive load of the quartz(x-tal).
    enum: [7000, 12500]

This just remove restriction, which allow only 7000 for nxp,pcf85063

Frank
>
> >
> > So remove it to fix below CHECK_DTBS warnings:
> > arch/arm/boot/dts/nxp/imx/imx6dl-skov-revc-lt2.dtb: rtc@51 (nxp,pcf85063): quartz-load-femtofarads:0: 7000 was expected
> >         from schema $id: http://devicetree.org/schemas/rtc/nxp,pcf85063.yaml#
> >
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> >  .../devicetree/bindings/rtc/nxp,pcf85063.yaml          | 10 ----------
> >  1 file changed, 10 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> > index 1e6277e524c27..f7013cd8fc20b 100644
> > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> > @@ -62,16 +62,6 @@ allOf:
> >      then:
> >        properties:
> >          quartz-load-femtofarads: false
> > -  - if:
> > -      properties:
> > -        compatible:
> > -          contains:
> > -            enum:
> > -              - nxp,pcf85063
> > -    then:
> > -      properties:
> > -        quartz-load-femtofarads:
> > -          const: 7000
> >    - if:
> >        properties:
> >          compatible:
> > --
> > 2.34.1
> >
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com