linux-kernel - Re: [PATCH 2/2] ASoC: replace use of system_wq with system_percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAofZF4XEFXWQEqeKJ3aTjPRuu5RgOEYRLX4Aeq=RGh7gnLGTQ@mail.gmail.com>
Date: Fri, 5 Sep 2025 18:00:04 +0200
From: Marco Crivellari <marco.crivellari@...e.com>
To: Mark Brown <broonie@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org, 
	Tejun Heo <tj@...nel.org>, Lai Jiangshan <jiangshanlai@...il.com>, 
	Frederic Weisbecker <frederic@...nel.org>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, 
	Michal Hocko <mhocko@...e.com>, Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>, 
	Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH 2/2] ASoC: replace use of system_wq with system_percpu_wq

Hello Mark,

The above change is just a 1:1 conversion.
system_wq is a per-cpu wq, so we only converted the name with the new one.
system_wq is still present in the code, for a few release cycles.

If the users don't care to be per-cpu, system_dfl_wq (the new unbound
wq) can be used instead.

This is just the first step of the conversion.

Thanks!


On Fri, Sep 5, 2025 at 12:54 PM Mark Brown <broonie@...nel.org> wrote:
>
> On Fri, Sep 05, 2025 at 11:10:16AM +0200, Marco Crivellari wrote:
>
> > +++ b/sound/soc/codecs/aw88081.c
> > @@ -779,7 +779,7 @@ static void aw88081_start(struct aw88081 *aw88081, bool sync_start)
> >       if (sync_start == AW88081_SYNC_START)
> >               aw88081_start_pa(aw88081);
> >       else
> > -             queue_delayed_work(system_wq,
> > +             queue_delayed_work(system_percpu_wq,
> >                       &aw88081->start_work,
> >                       AW88081_START_WORK_DELAY_MS);
> >  }
>
> I can't tell why you're putting all these onto the percpu workqeue, I
> would be astonished if any of the users cared.



-- 

Marco Crivellari

L3 Support Engineer, Technology & Product




marco.crivellari@...e.com