linux-kernel - Re: [PATCH v3 06/12] ASoC: codecs: wcd: add common helper for wcd codecs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <r2vk6rus2ownex4hunrwxutbrbsggmbe7lgiiksetum72y5scn@6kd55k5cdpr4>
Date: Fri, 5 Sep 2025 19:42:56 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
Cc: broonie@...nel.org, lgirdwood@...il.com, tiwai@...e.com, vkoul@...nel.org,
        srini@...nel.org, yung-chuan.liao@...ux.intel.com,
        pierre-louis.bossart@...ux.dev, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, neil.armstrong@...aro.org,
        krzysztof.kozlowski@...aro.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH v3 06/12] ASoC: codecs: wcd: add common helper for wcd
 codecs

On Fri, Sep 05, 2025 at 04:44:24PM +0100, Srinivas Kandagatla wrote:
> All the Qualcomm WCD codecs have most of its code duplicated across all
> these 3/4 drivers. This is an attempt to remove those duplicate
> parts by adding a common helper library for these codecs.
> 
> To start with move all the micbias parsing and voltage settings these
> are identical in WCD934x, WCD937x, WCD938x and WCD939x codec driver.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
> ---
>  sound/soc/codecs/Kconfig      |  8 ++++
>  sound/soc/codecs/Makefile     |  2 +
>  sound/soc/codecs/wcd-common.c | 70 +++++++++++++++++++++++++++
>  sound/soc/codecs/wcd-common.h | 27 +++++++++++
>  sound/soc/codecs/wcd934x.c    | 82 +++++++++----------------------
>  sound/soc/codecs/wcd937x.c    | 75 +++++++----------------------
>  sound/soc/codecs/wcd937x.h    |  6 +--
>  sound/soc/codecs/wcd938x.c    | 88 +++++++---------------------------
>  sound/soc/codecs/wcd939x.c    | 90 +++++++----------------------------
>  9 files changed, 183 insertions(+), 265 deletions(-)
>  create mode 100644 sound/soc/codecs/wcd-common.c
>  create mode 100644 sound/soc/codecs/wcd-common.h
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>


-- 
With best wishes
Dmitry