linux-kernel - Re: [PATCH 3/3] workqueue: WQ_PERCPU added to alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aLsdBIY01140Vyy_@slm.duckdns.org>
Date: Fri, 5 Sep 2025 07:25:24 -1000
From: Tejun Heo <tj@...nel.org>
To: Marco Crivellari <marco.crivellari@...e.com>
Cc: linux-kernel@...r.kernel.org, Lai Jiangshan <jiangshanlai@...il.com>,
	Frederic Weisbecker <frederic@...nel.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH 3/3] workqueue: WQ_PERCPU added to alloc_workqueue users

Hello,

The patch doesn't apply to wq/for-6.18 and...

> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 89839eebb359..d33ca6acc5a5 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -7819,22 +7819,23 @@ void __init workqueue_init_early(void)
>  		ordered_wq_attrs[i] = attrs;
>  	}
>  
> -	system_wq = alloc_workqueue("events", 0, 0);
> -	system_percpu_wq = alloc_workqueue("events", 0, 0);
> -	system_highpri_wq = alloc_workqueue("events_highpri", WQ_HIGHPRI, 0);
> -	system_long_wq = alloc_workqueue("events_long", 0, 0);
> +	system_wq = alloc_workqueue("events", WQ_PERCPU, 0);
> +	system_percpu_wq = alloc_workqueue("events", WQ_PERCPU, 0);
> +	system_highpri_wq = alloc_workqueue("events_highpri",
> +					    WQ_HIGHPRI | WQ_PERCPU, 0);
> +	system_long_wq = alloc_workqueue("events_long", WQ_PERCPU, 0);
>  	system_unbound_wq = alloc_workqueue("events_unbound", WQ_UNBOUND, WQ_MAX_ACTIVE);
>  	system_dfl_wq = alloc_workqueue("events_unbound", WQ_UNBOUND, WQ_MAX_ACTIVE);
>  	system_freezable_wq = alloc_workqueue("events_freezable",
> -					      WQ_FREEZABLE, 0);
> +					      WQ_FREEZABLE | WQ_PERCPU, 0);
>  	system_power_efficient_wq = alloc_workqueue("events_power_efficient",
>  					      WQ_POWER_EFFICIENT, 0);
>  	system_freezable_power_efficient_wq = alloc_workqueue("events_freezable_pwr_efficient",
> -					      WQ_FREEZABLE | WQ_POWER_EFFICIENT,
> -					      0);
> -	system_bh_wq = alloc_workqueue("events_bh", WQ_BH, 0);
> +					      WQ_FREEZABLE | WQ_POWER_EFFICIENT, 0);

Isn't this missing WQ_PERCPU for system_freezable_power_efficient_wq?

Thanks.

-- 
tejun