linux-kernel - Re: [PATCH v2] cpufreq: Drop redundant freq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gApi4_3gcLkCM5dw4MBsTOHB2hCn7oo5Vy_Hkk-oxbSA@mail.gmail.com>
Date: Fri, 5 Sep 2025 20:16:20 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: Zihuan Zhang <zhangzihuan@...inos.cn>, "Rafael J . wysocki" <rafael@...nel.org>, 
	zhenglifeng <zhenglifeng1@...wei.com>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] cpufreq: Drop redundant freq_table parameter

On Tue, Sep 2, 2025 at 9:56 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> On 02-09-25, 15:33, Zihuan Zhang wrote:
> > Since commit e0b3165ba521 ("cpufreq: add 'freq_table' in struct
> > cpufreq_policy"),
> > freq_table has been stored in struct cpufreq_policy instead of being
> > maintained separately.
> >
> > However, several helpers in freq_table.c still take both policy and
> > freq_table as parameters, even though policy->freq_table can always be
> > used. This leads to redundant function arguments and increases the chance
> > of inconsistencies.
> >
> > This patch removes the unnecessary freq_table argument from these functions
> > and updates their callers to only pass policy. This makes the code simpler,
> > more consistent, and avoids duplication.
> >
> > V2:
> >  - Merge three patches into one to fix compile error
> >  - simple the check suggested by Viresh Kumar
> >
> > Signed-off-by: Zihuan Zhang <zhangzihuan@...inos.cn>
> > ---
> >  drivers/cpufreq/cpufreq.c         |  2 +-
> >  drivers/cpufreq/freq_table.c      | 14 ++++++--------
> >  drivers/cpufreq/sh-cpufreq.c      |  6 ++----
> >  drivers/cpufreq/virtual-cpufreq.c |  2 +-
> >  include/linux/cpufreq.h           |  7 +++----
> >  5 files changed, 13 insertions(+), 18 deletions(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

Applied as 6.18 material, thanks!