linux-kernel - Re: [PATCH 2/3] mm: remove unused zpool layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <rcxmemdxbxuvtag2qv4sjxoh7ho4z3bz3od6i76rc5yholx2rc@vncn6iuuee7b>
Date: Fri, 5 Sep 2025 18:58:47 +0000
From: Yosry Ahmed <yosry.ahmed@...ux.dev>
To: Johannes Weiner <hannes@...xchg.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, 
	Nhat Pham <nphamcs@...il.com>, Chengming Zhou <zhouchengming@...edance.com>, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] mm: remove unused zpool layer

On Fri, Aug 29, 2025 at 05:15:27PM +0100, Johannes Weiner wrote:
> With zswap using zsmalloc directly, there are no more in-tree users of
> this code. Remove it.
> 
> Signed-off-by: Johannes Weiner <hannes@...xchg.org>
> ---
[..]
> @@ -125,45 +122,18 @@ config ZSWAP_COMPRESSOR_DEFAULT
>         default "zstd" if ZSWAP_COMPRESSOR_DEFAULT_ZSTD
>         default ""
>  
> -choice
> -	prompt "Default allocator"
> -	depends on ZSWAP
> -	default ZSWAP_ZPOOL_DEFAULT_ZSMALLOC if MMU
> -	help
> -	  Selects the default allocator for the compressed cache for
> -	  swap pages.
> -	  The default is 'zbud' for compatibility, however please do
> -	  read the description of each of the allocators below before
> -	  making a right choice.
> -
> -	  The selection made here can be overridden by using the kernel
> -	  command line 'zswap.zpool=' option.
> +config ZSMALLOC
> +	tristate
>  
> -config ZSWAP_ZPOOL_DEFAULT_ZSMALLOC
> -	bool "zsmalloc"
> -	select ZSMALLOC
> -	help
> -	  Use the zsmalloc allocator as the default allocator.
> -endchoice
> +if ZSMALLOC
>  
> -config ZSWAP_ZPOOL_DEFAULT
> -       string
> -       depends on ZSWAP
> -       default "zsmalloc" if ZSWAP_ZPOOL_DEFAULT_ZSMALLOC
> -       default ""
> +menu "Zsmalloc allocator options"
> +	depends on ZSMALLOC
>  
> -config ZSMALLOC
> -	tristate
> -	prompt "N:1 compression allocator (zsmalloc)" if (ZSWAP || ZRAM)
> -	depends on MMU
> -	help
> -	  zsmalloc is a slab-based memory allocator designed to store
> -	  pages of various compression levels efficiently. It achieves
> -	  the highest storage density with the least amount of fragmentation.

Why remove the prompt and help text here?

> +comment "Zsmalloc is a common backend allocator for zswap & zram"
>  
>  config ZSMALLOC_STAT
>  	bool "Export zsmalloc statistics"
> -	depends on ZSMALLOC
>  	select DEBUG_FS
>  	help
>  	  This option enables code in the zsmalloc to collect various
[..]