linux-kernel - Re: [PATCH -v1 1/2] x86/microcode: Add microcode= cmdline parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250905192722.GA1274334@ax162>
Date: Fri, 5 Sep 2025 12:27:22 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Ryusuke Konishi <konishi.ryusuke@...il.com>
Cc: Borislav Petkov <bp@...en8.de>,
	kernel test robot <oliver.sang@...el.com>,
	Borislav Petkov <bp@...nel.org>, oe-lkp@...ts.linux.dev,
	lkp@...el.com, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, X86 ML <x86@...nel.org>,
	"Chang S. Bae" <chang.seok.bae@...el.com>,
	Sohil Mehta <sohil.mehta@...el.com>, linux-nilfs@...r.kernel.org
Subject: Re: [PATCH -v1 1/2] x86/microcode: Add microcode= cmdline parsing

On Fri, Sep 05, 2025 at 10:17:26PM +0900, Ryusuke Konishi wrote:
> Thank you very much, Nathan, for sharing your detailed report and
> proposing a fix.
> 
> I actually performed a reproduction test in an environment with
> CONFIG_LTO_CLANG_THIN=y and confirmed that the CFI panic reoccurs, and
> that your patch fixes it.
> 
> I also followed your analysis of sysfs and concluded that it is
> correct and that your changes to the two
> nilfs_feature_{revision,README}_show() functions are necessary. I'll
> check whether these were necessary from the beginning or whether they
> became necessary later.
> 
> I'd like to send your proposed fixes upstream, but could you please
> send it to me and linux-nilfs in the form of a proper patch? (I'll
> need at least your SoB line).

Thanks for taking a look and confirming :) I have sent a patch with a
proper changelog along for you to take a look at.

https://lore.kernel.org/20250905-nilfs2-fix-features-cfi-violation-v1-1-b5d35136d813@kernel.org/

>From what I can tell, this has always been wrong, hence that Fixes tag
but if you disagree, feel free to update it!

Cheers,
Nathan