[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250905204148.GA1313142-robh@kernel.org>
Date: Fri, 5 Sep 2025 15:41:48 -0500
From: Rob Herring <robh@...nel.org>
To: Kendall Willis <k-willis@...com>
Cc: gregkh@...uxfoundation.org, jirislaby@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, vigneshr@...com, linux-kernel@...r.kernel.org,
linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
d-gole@...com, vishalm@...com, sebin.francis@...com,
msp@...libre.com, khilman@...libre.com, a-kaur@...com,
john.ogness@...utronix.de, andriy.shevchenko@...ux.intel.com,
yujiaoliang@...o.com, b-liu@...com, u.kleine-koenig@...libre.com
Subject: Re: [PATCH 2/3] dt-bindings: serial: 8250_omap: Add wakeup pinctrl
state
On Thu, Sep 04, 2025 at 04:24:54PM -0500, Kendall Willis wrote:
> From: Markus Schneider-Pargmann <msp@...libre.com>
>
> Pins associated with the 8250 omap unit can be the source of a wakeup in
> deep sleep states. To be able to wakeup, these pins have to be
> configured in a special way. To support this configuration add the
> default and wakeup pinctrl states. Add support for the sleep state as
> well which is in use by some devicetrees.
>
> Signed-off-by: Markus Schneider-Pargmann <msp@...libre.com>
> Signed-off-by: Kendall Willis <k-willis@...com>
> ---
> .../devicetree/bindings/serial/8250_omap.yaml | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/8250_omap.yaml b/Documentation/devicetree/bindings/serial/8250_omap.yaml
> index 851a5291b4be4..1c4040a9f9d0b 100644
> --- a/Documentation/devicetree/bindings/serial/8250_omap.yaml
> +++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml
> @@ -77,6 +77,23 @@ properties:
> description:
> List of phandles to system idle states in which UARTs can wakeup the system.
>
> + pinctrl-0:
> + description: Default pinctrl state
> +
> + pinctrl-1:
> + description: Can be "sleep" or "wakeup" pinctrl state
> +
> + pinctrl-names:
> + description:
> + When present should contain at least "default" describing the default pin
> + states. Other states are "sleep" which describes the pinstate when
> + sleeping and "wakeup" describing the pins if wakeup is enabled.
> + minItems: 1
> + items:
> + - const: default
> + - const: sleep
> + - const: wakeup
This doesn't match what 'pinctrl-1' says. Perhaps you want?:
items:
- const: default
- enum: [ sleep, wakeup ]
> +
> required:
> - compatible
> - reg
> --
> 2.34.1
>
Powered by blists - more mailing lists