linux-kernel - Re: [PATCH for-6.18/block 05/16] blk-crypto: fix missing blktrace bio split events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6ed7605-53c6-45f4-9e6a-078353104cef@acm.org>
Date: Fri, 5 Sep 2025 13:45:39 -0700
From: Bart Van Assche <bvanassche@....org>
To: Yu Kuai <yukuai1@...weicloud.com>, hch@...radead.org, colyli@...nel.org,
 hare@...e.de, dlemoal@...nel.org, tieren@...as.com, axboe@...nel.dk,
 tj@...nel.org, josef@...icpanda.com, song@...nel.org, yukuai3@...wei.com,
 satyat@...gle.com, ebiggers@...gle.com, kmo@...erainc.com,
 akpm@...ux-foundation.org, neil@...wn.name
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 cgroups@...r.kernel.org, linux-raid@...r.kernel.org, yi.zhang@...wei.com,
 yangerkun@...wei.com, johnny.chenyi@...wei.com
Subject: Re: [PATCH for-6.18/block 05/16] blk-crypto: fix missing blktrace bio
 split events

On 9/5/25 12:06 AM, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@...wei.com>
> 
> trace_block_split() is missing, resulting in blktrace inability to catch
> BIO split events and making it harder to analyze the BIO sequence.
> 
> Cc: stable@...r.kernel.org
> Fixes: 488f6682c832 ("block: blk-crypto-fallback for Inline Encryption")
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> ---
>   block/blk-crypto-fallback.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c
> index 005c9157ffb3..1f9a4c33d2bd 100644
> --- a/block/blk-crypto-fallback.c
> +++ b/block/blk-crypto-fallback.c
> @@ -18,6 +18,7 @@
>   #include <linux/module.h>
>   #include <linux/random.h>
>   #include <linux/scatterlist.h>
> +#include <trace/events/block.h>
>   
>   #include "blk-cgroup.h"
>   #include "blk-crypto-internal.h"
> @@ -231,7 +232,9 @@ static bool blk_crypto_fallback_split_bio_if_needed(struct bio **bio_ptr)
>   			bio->bi_status = BLK_STS_RESOURCE;
>   			return false;
>   		}
> +
>   		bio_chain(split_bio, bio);
> +		trace_block_split(split_bio, bio->bi_iter.bi_sector);
>   		submit_bio_noacct(bio);
>   		*bio_ptr = split_bio;
>   	}

Ah, here it is. Hence:

Reviewed-by: Bart Van Assche <bvanassche@....org>