linux-kernel - Re: [PATCH 1/1] clk: ti: am33xx: keep WKUP_DEBUGSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7hms78a897.fsf@baylibre.com>
Date: Fri, 05 Sep 2025 14:40:04 -0700
From: Kevin Hilman <khilman@...nel.org>
To: Alexander Stein <alexander.stein@...tq-group.com>, Tero Kristo
 <kristo@...nel.org>, Michael Turquette <mturquette@...libre.com>, Stephen
 Boyd <sboyd@...nel.org>
Cc: Matthias Schiffer <matthias.schiffer@...group.com>,
 linux-omap@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org, Alexander Stein
 <alexander.stein@...tq-group.com>
Subject: Re: [PATCH 1/1] clk: ti: am33xx: keep WKUP_DEBUGSS_CLKCTRL enabled

Alexander Stein <alexander.stein@...tq-group.com> writes:

> From: Matthias Schiffer <matthias.schiffer@...group.com>
>
> As described in AM335x Errata Advisory 1.0.42, WKUP_DEBUGSS_CLKCTRL
> can't be disabled - the clock module will just be stuck in transitioning
> state forever, resulting in the following warning message after the wait
> loop times out:
>
>     l3-aon-clkctrl:0000:0: failed to disable
>
> Just add the clock to enable_init_clks, so no attempt is made to disable
> it.
>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@...group.com>
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>

Acked-by: Kevin Hilman <khilman@...libre.com>

> ---
>  drivers/clk/ti/clk-33xx.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/ti/clk-33xx.c b/drivers/clk/ti/clk-33xx.c
> index 85c50ea39e6da..9269e6a0db6a4 100644
> --- a/drivers/clk/ti/clk-33xx.c
> +++ b/drivers/clk/ti/clk-33xx.c
> @@ -258,6 +258,8 @@ static const char *enable_init_clks[] = {
>  	"dpll_ddr_m2_ck",
>  	"dpll_mpu_m2_ck",
>  	"l3_gclk",
> +	/* WKUP_DEBUGSS_CLKCTRL - disable fails, AM335x Errata Advisory 1.0.42 */
> +	"l3-aon-clkctrl:0000:0",
>  	/* AM3_L3_L3_MAIN_CLKCTRL, needed during suspend */
>  	"l3-clkctrl:00bc:0",
>  	"l4hs_gclk",
> -- 
> 2.43.0