linux-kernel - Re: [PATCH v2 3/8] dt-bindings: clock: rk3368: Add SCLK_MIPIDSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2267196.NgBsaNRSFp@diego>
Date: Fri, 05 Sep 2025 07:52:47 +0200
From: Heiko Stübner <heiko@...ech.de>
To: robh@...nel.org, WeiHao Li <cn.liweihao@...il.com>
Cc: hjc@...k-chips.com, andy.yan@...k-chips.com, krzk+dt@...nel.org,
 conor+dt@...nel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
 WeiHao Li <cn.liweihao@...il.com>
Subject: Re: [PATCH v2 3/8] dt-bindings: clock: rk3368: Add SCLK_MIPIDSI_24M

Hi,

Am Freitag, 5. September 2025, 04:56:27 Mitteleuropäische Sommerzeit schrieb WeiHao Li:
> Add a clock id for mipi dsi reference clock, mipi dsi node used it.
> 
> Signed-off-by: WeiHao Li <cn.liweihao@...il.com>

another process-related comment :-) .

(1) You already got in v1 the
Acked-by: Rob Herring (Arm) <robh@...nel.org>

So when sending a v2, please include such received tags
(if there are no major changes to the relevant code)

This prevents people from reviewing things needlessly multiple times.
So patch 3 would look something like:

------------
Add a clock id for mipi dsi reference clock, mipi dsi node used it.

Acked-by: Rob Herring (Arm) <robh@...nel.org>
Signed-off-by: WeiHao Li <cn.liweihao@...il.com>
------------

(2) As can be seen in
https://lore.kernel.org/linux-rockchip/175690195013.3771488.435870786224873257.b4-ty@sntech.de/

I already applied the two clock patches, so in newer versions don't
send them anymore.


Just to keep in mind for next time.


Heiko

> ---
>  include/dt-bindings/clock/rk3368-cru.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/dt-bindings/clock/rk3368-cru.h b/include/dt-bindings/clock/rk3368-cru.h
> index ebae3cbf8..b951e2906 100644
> --- a/include/dt-bindings/clock/rk3368-cru.h
> +++ b/include/dt-bindings/clock/rk3368-cru.h
> @@ -72,6 +72,7 @@
>  #define SCLK_SFC		126
>  #define SCLK_MAC		127
>  #define SCLK_MACREF_OUT		128
> +#define SCLK_MIPIDSI_24M	129
>  #define SCLK_TIMER10		133
>  #define SCLK_TIMER11		134
>  #define SCLK_TIMER12		135
>