linux-kernel - Re: [PATCH v2 09/16] staging: rtl8723bs: fix excessive indentation in nested if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f80045f-a8ec-46ae-ad83-4c93027a353e@gmail.com>
Date: Fri, 5 Sep 2025 02:31:20 -0400
From: Vivek BalachandharTN <vivek.balachandhar@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 09/16] staging: rtl8723bs: fix excessive indentation in
 nested if statement

Ack. Will fix this.

Best,
Vivek

On 2025-09-04 4:04 a.m., Dan Carpenter wrote:
> On Thu, Sep 04, 2025 at 02:14:41AM +0000, Vivek BalachandharTN wrote:
>> Adjust indentation in a nested if-statement to match kernel coding
>> style and improve readability.
>>
>> No functional changes.
>>
>> Signed-off-by: Vivek BalachandharTN <vivek.balachandhar@...il.com>
>> ---
>>   drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
>> index d05ff073af2d..a2b1e34765ac 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
>> @@ -1254,8 +1254,8 @@ void rtw_joinbss_event_prehandle(struct adapter *adapter, u8 *pbuf)
>>   
>>   					ptarget_wlan = rtw_find_network(&pmlmepriv->scanned_queue, pnetwork->network.mac_address);
>>   					if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) == true) {
>> -						if (ptarget_wlan)
>> -							ptarget_wlan->fixed = true;
>> +					    if (ptarget_wlan)
>> +						ptarget_wlan->fixed = true;
> Wait, what?  We're moving from tabs to 4 space indents?
>
> regards,
> dan carpenter
>