linux-kernel - Re: [PATCH v3 4/7] media: platform: amd: isp4 subdev and firmware loading handling added

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92bd4d65-a74c-4123-9a92-b7530699ad25@amd.com>
Date: Fri, 5 Sep 2025 14:35:18 +0800
From: "Du, Bin" <bin.du@....com>
To: Markus Elfring <Markus.Elfring@....de>,
 Svetoslav Stoilov <Svetoslav.Stoilov@....com>, linux-media@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Anson Tsao <anson.tsao@....com>,
 Benjamin Chan <benjamin.chan@....com>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Dominic Antony <Dominic.Antony@....com>,
 Gjorgji Rosikopulos <gjorgji.rosikopulos@....com>,
 Hans Verkuil <hverkuil@...all.nl>, King Li <king.li@....com>,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
 Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
 Mario Limonciello <mario.limonciello@....com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Phil Jawich
 <Phil.Jawich@....com>, Pratap Nirujogi <Pratap.Nirujogi@....com>,
 Richard Gong <richard.gong@....com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Sultan Alsawaf <sultan@...neltoast.com>
Subject: Re: [PATCH v3 4/7] media: platform: amd: isp4 subdev and firmware
 loading handling added

Thanks Markus Elfring.

On 9/2/2025 3:48 PM, Markus Elfring wrote:
> …
>> states, stream configuration and mipi phy configuration. This change also
> …
> 
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc4#n94
> 
> 

Very clear guide, will update in the next version and also check commit 
message of other patches in the series.

> …
>> +++ b/drivers/media/platform/amd/isp4/isp4_subdev.c
>> @@ -0,0 +1,1096 @@
> …
>> +static s32 isp4sd_fw_resp_thread_wrapper(void *context)
>> +{
> …
>> +		mutex_lock(&thread_ctx->mutex);
>> +		isp4sd_fw_resp_func(isp_subdev, stream_id);
>> +		mutex_unlock(&thread_ctx->mutex);
> …
> 
> Under which circumstances would you become interested to apply a statement
> like “guard(mutex)(&thread_ctx->mutex);”?
> https://elixir.bootlin.com/linux/v6.17-rc4/source/include/linux/mutex.h#L228
> 

Appreciate for catching this, will do the optimization in the next version.

> Regards,
> Markus

-- 
Regards,
Bin