linux-kernel - Re: [PATCH] mfd: tps6594: Explicitly include bitfield.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DCKNRRN0Q2I7.WFT5U4QKA9XS@kernel.org>
Date: Fri, 05 Sep 2025 08:38:31 +0200
From: "Michael Walle" <mwalle@...nel.org>
To: "Nathan Chancellor" <nathan@...nel.org>, "Lee Jones" <lee@...nel.org>,
 "Job Sava" <jsava@...ticallink.com>
Cc: <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: tps6594: Explicitly include bitfield.h

Hi Nathan,

On Fri Sep 5, 2025 at 3:26 AM CEST, Nathan Chancellor wrote:
> After a recent change that started using FIELD_GET() in tps6594-core.c,
> there is an error when bitfield.h is not implicitly included, such as
> when building allmodconfig for ARCH=hexagon:

Thanks! I was already in a discussion with Lee about how to handle
that.

>   drivers/mfd/tps6594-core.c:767:7: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>     767 |                 if (FIELD_GET(TPS65224_MASK_EN_PB_VSENSE_CONFIG, pwr_on) == TPS65224_EN_SEL_PB ||
>         |                     ^
>
> Explicitly include bitfield.h to resolve the errors.
>
> Fixes: d766ca01c208 ("mfd: tps6594: Add power button functionality")
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>

In any case:
Reviewed-by: Michael Walle <mwalle@...nel.org>

Also,
Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202509032356.LGa5hygM-lkp@intel.com/

> ---
> It looks like this should go into ib-mfd-input-6.18.

Yeah probably. Lee, is that possible?

-michael

Download attachment "signature.asc" of type "application/pgp-signature" (298 bytes)