linux-kernel - Re: [PATCH v2 1/8] dt-bindings: memory: tegra210: Add memory client IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c64f09f5-440f-411d-b2f1-6c85b9adffb7@kernel.org>
Date: Fri, 5 Sep 2025 08:56:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Aaron Kling <webgeek1234@...il.com>
Cc: Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Thierry Reding <thierry.reding@...il.com>,
 Jonathan Hunter <jonathanh@...dia.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 MyungJoo Ham <myungjoo.ham@...sung.com>,
 Kyungmin Park <kyungmin.park@...sung.com>,
 Chanwoo Choi <cw00.choi@...sung.com>, Dmitry Osipenko <digetx@...il.com>,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-tegra@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 1/8] dt-bindings: memory: tegra210: Add memory client
 IDs

On 04/09/2025 19:33, Aaron Kling wrote:
> On Thu, Sep 4, 2025 at 3:20 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>
>> On Wed, Sep 03, 2025 at 02:50:07PM -0500, Aaron Kling wrote:
>>> Each memory client has unique hardware ID, add these IDs.
>>>
>>> Signed-off-by: Aaron Kling <webgeek1234@...il.com>
>>> ---
>>>  include/dt-bindings/memory/tegra210-mc.h | 58 ++++++++++++++++++++++++++++++++
>>>  1 file changed, 58 insertions(+)
>>>
>>> diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindings/memory/tegra210-mc.h
>>> index 5e082547f1794cba1f72872782e04d8747863b6d..48474942a000e049142014e3bcc132b88bf1a92d 100644
>>> --- a/include/dt-bindings/memory/tegra210-mc.h
>>> +++ b/include/dt-bindings/memory/tegra210-mc.h
>>> @@ -75,4 +75,62 @@
>>>  #define TEGRA210_MC_RESET_ETR                28
>>>  #define TEGRA210_MC_RESET_TSECB              29
>>>
>>> +#define TEGRA210_MC_PTCR             0
>>
>> There is no driver user of this ABI, so does not look like a binding.
>>
>> You have entire commit msg to clarify such unusual things, like lack of
>> users. Please use it.
> 
> The tegra210-mc driver has these hardcoded and should probably be
> updated to use the bindings instead, but I think that's outside of the
> scope of this series. I will clarify such in the updated message.

If you introduce the binding, change the drivers to use it. Otherwise
there is no point benefit in this binding, really.

> 
> Aaron


Best regards,
Krzysztof