[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7c0ea575-7682-4601-8922-49684d929374@linux.alibaba.com>
Date: Fri, 5 Sep 2025 09:19:32 +0800
From: Shuai Xue <xueshuai@...ux.alibaba.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
"Rafael J. Wysocki" <rafael@...nel.org>, Tony Luck <tony.luck@...el.com>,
Borislav Petkov <bp@...en8.de>, Hanjun Guo <guohanjun@...wei.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>, Len Brown <lenb@...nel.org>,
Al Viro <viro@...iv.linux.org.uk>
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: APEI: Remove redundant assignments in
erst_dbg_{ioctl|write}()
在 2025/9/4 06:49, Thorsten Blum 写道:
> Use the result of copy_from_user() directly instead of assigning it to
> the local variable 'rc' and then overwriting it in erst_dbg_write() or
> immediately returning from erst_dbg_ioctl().
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
> drivers/acpi/apei/erst-dbg.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/acpi/apei/erst-dbg.c b/drivers/acpi/apei/erst-dbg.c
> index 246076341e8c..ff0e8bf8e97a 100644
> --- a/drivers/acpi/apei/erst-dbg.c
> +++ b/drivers/acpi/apei/erst-dbg.c
> @@ -60,9 +60,8 @@ static long erst_dbg_ioctl(struct file *f, unsigned int cmd, unsigned long arg)
>
> switch (cmd) {
> case APEI_ERST_CLEAR_RECORD:
> - rc = copy_from_user(&record_id, (void __user *)arg,
> - sizeof(record_id));
> - if (rc)
> + if (copy_from_user(&record_id, (void __user *)arg,
> + sizeof(record_id)))
> return -EFAULT;
> return erst_clear(record_id);
> case APEI_ERST_GET_RECORD_COUNT:
> @@ -175,8 +174,7 @@ static ssize_t erst_dbg_write(struct file *filp, const char __user *ubuf,
> erst_dbg_buf = p;
> erst_dbg_buf_len = usize;
> }
> - rc = copy_from_user(erst_dbg_buf, ubuf, usize);
> - if (rc) {
> + if (copy_from_user(erst_dbg_buf, ubuf, usize)) {
> rc = -EFAULT;
> goto out;
> }
Hi Thorsten,
Thanks for the patch.
The changes look good to me.
Since this is a code cleanup with no functional changes, could you
please mention "no functional change" or similar wording in the commit
message to make it clear?
With that addressed:
Reviewed-by: Shuai Xue <xueshuai@...ux.alibaba.com>
Thanks,
Shuai
Powered by blists - more mailing lists