[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <aLqZBh5_dSHUb4AE@stanley.mountain>
Date: Fri, 5 Sep 2025 11:02:14 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Stefan Kerkmann <s.kerkmann@...gutronix.de>
Cc: Brian Norris <briannorris@...omium.org>,
Francesco Dolcini <francesco@...cini.it>,
Johannes Berg <johannes.berg@...el.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Jeff Chen <jeff.chen_1@....com>, linux-wireless@...r.kernel.org,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [PATCH next] wifi: mwifiex: fix double free in
mwifiex_send_rgpower_table()
The "hostcmd" is freed using cleanup.h, so calling kfree() will lead to
a double free. Delete the kfree().
Fixes: 7b6f16a25806 ("wifi: mwifiex: add rgpower table loading support")
Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
---
drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
index 6d9e2af29a69..91d5098081e8 100644
--- a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
+++ b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
@@ -1521,10 +1521,8 @@ int mwifiex_send_rgpower_table(struct mwifiex_private *priv, const u8 *data,
return -ENOMEM;
_data = kmemdup(data, size, GFP_KERNEL);
- if (!_data) {
- kfree(hostcmd);
+ if (!_data)
return -ENOMEM;
- }
pos = _data;
ptr = hostcmd->cmd;
--
2.47.2
Powered by blists - more mailing lists