linux-kernel - Re: [PATCH] clocksource/drivers/exynos_mct: only use IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADrjBPqjw82MuxctT5oxHWX7J4D0yghtO6Md8WkJHz5-6LkP3g@mail.gmail.com>
Date: Fri, 5 Sep 2025 09:15:37 +0100
From: Peter Griffin <peter.griffin@...aro.org>
To: Marek Szyprowski <m.szyprowski@...sung.com>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>, Thomas Gleixner <tglx@...utronix.de>, 
	Krzysztof Kozlowski <krzk@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>, 
	Ingo Molnar <mingo@...nel.org>, Will McVicker <willmcvicker@...gle.com>, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, 
	Tudor Ambarus <tudor.ambarus@...aro.org>, André Draszik <andre.draszik@...aro.org>, 
	John Stultz <jstultz@...gle.com>, kernel-team@...roid.com, youngmin.nam@...sung.com, 
	hoony.yu@...sung.com
Subject: Re: [PATCH] clocksource/drivers/exynos_mct: only use IRQF_PERCPU flag
 on ARM64 SoCs

Hi Marek,

On Thu, 4 Sept 2025 at 18:49, Marek Szyprowski <m.szyprowski@...sung.com> wrote:
>
> On 04.09.2025 17:32, Peter Griffin wrote:
> > This patch addresses a regression reported in [1] whereby CPU hotplug now
> > fails on little CPUs (for reasons that aren't fully understood) for Arm
> > 32bit platforms such as Exynos 5422 used in OdroidXU3/XU4 boards.
> >
> > Note: This patch makes an assumption that the exynos_mct driver is only
> > used on Arm 32/64 bit SoCs.
> >
> > Fixes: f3cec54ee3bf ("clocksource/drivers/exynos_mct: Set local timer interrupts as percpu")
> > Reported-by: Marek Szyprowski <m.szyprowski@...sung.com>
> > Closes: https://lore.kernel.org/lkml/8c861182-7e90-4bbf-ac04-173d59f5af69@samsung.com/
> > Link: https://lore.kernel.org/lkml/8c861182-7e90-4bbf-ac04-173d59f5af69@samsung.com/ [1]
> > Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
> > ---
> > Hi Marek & Krzysztof,
> >
> > Can you test this patch on your Exynos5422 based boards and see if it
> > resolves the issue Marek reported of CPU hot plug failing on the little
> > cores of Exynos 5422 based boards?
> >
> > Unfortunately I only have gs101 based Exynos hardware (which is Arm 64 bit
> > SoC) to test on. I can confirm CPU hotplug is functional on the little
> > cluster CPUs with IRQF_PERCPU flag on Pixel6/gs101 though.
>
> This is a duplicate of
> https://lore.kernel.org/all/20250827102645.1964659-1-m.szyprowski@samsung.com/
>
> and yes, it fixes the reported issue.
>
> Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>

Sorry I hadn't noticed your patch for this. Let's go with your fix
then as it seems more succinct.

Thanks,

Peter