| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <3636099d5d0b31ebf232a5b2e741f0ff7e7e1631.1757061697.git.michal.simek@amd.com>
Date: Fri, 5 Sep 2025 10:41:49 +0200
From: Michal Simek <michal.simek@....com>
To: <linux-kernel@...r.kernel.org>, <monstr@...str.eu>,
<michal.simek@...inx.com>, <git@...inx.com>
CC: Anish Kadamathikuttiyil Karthikeyan Pillai
<anish.kadamathikuttiyil-karthikeyan-pillai@....com>, Daniel Lezcano
<daniel.lezcano@...aro.org>, Lukasz Luba <lukasz.luba@....com>, "Rafael J.
Wysocki" <rafael@...nel.org>, Salih Erim <salih.erim@....com>, Zhang Rui
<rui.zhang@...el.com>, "open list:THERMAL" <linux-pm@...r.kernel.org>
Subject: [PATCH 6/6] thermal: versal-thermal: Support thermal management in AI Engine
From: Anish Kadamathikuttiyil Karthikeyan Pillai <anish.kadamathikuttiyil-karthikeyan-pillai@....com>
For AI Engine thermal monitoring, through the thermal framework,
a new temperature zone is added. The temperature of versal sysmon
satellites near to AI Engine is read from the mapped IIO channels.
The maximum value of temperature from versal sysmon satellites
near AI Engine will be reported.
In versal thermal driver iio channel names are read from versal
sysmon temp child node. The reason is we cannot specify the
iio-channel-names in versal thermal sensor node, as it can change from
board to board and versal_thermal node which is not related
to any hardware.
Passing NULL is not be supported by devm_ API for getting IIO
channel names. So we moved from this approach to iio_channel_get approach.
Signed-off-by: Anish Kadamathikuttiyil Karthikeyan Pillai <anish.kadamathikuttiyil-karthikeyan-pillai@....com>
Signed-off-by: Michal Simek <michal.simek@....com>
---
drivers/thermal/versal_thermal.c | 146 +++++++++++++++++++++++++++++--
1 file changed, 140 insertions(+), 6 deletions(-)
diff --git a/drivers/thermal/versal_thermal.c b/drivers/thermal/versal_thermal.c
index 51c8586af5a4..e2e201c5c955 100644
--- a/drivers/thermal/versal_thermal.c
+++ b/drivers/thermal/versal_thermal.c
@@ -13,11 +13,17 @@
#define SYSMON_TEMP_CH_NAME "sysmon-temp-channel"
#define SYSMON_FRACTIONAL_DENOM 128
+#define SYSMON_STATIC_IIO_CH_COUNT 1
+#define SYSMON_AIE_TEMP_CH 200
+#define TEMP_MAX 160
struct versal_thermal_info {
struct device *dev;
struct thermal_zone_device *tzd;
+ struct thermal_zone_device *tzd_aie;
struct iio_channel *channel;
+ struct iio_channel **channel_aie;
+ u32 num_aie_channels;
};
static int temperature_sensor_get_temp(struct thermal_zone_device *tz, int *temp)
@@ -39,31 +45,158 @@ static int temperature_sensor_get_temp(struct thermal_zone_device *tz, int *temp
return 0;
}
+static int temperature_sensor_get_temp_aie(struct thermal_zone_device *tz,
+ int *temp)
+{
+ struct versal_thermal_info *vti = thermal_zone_device_priv(tz);
+ int ret, val;
+ int max_temp = INT_MIN;
+ u32 aie_ch_index;
+
+ for (aie_ch_index = 0; aie_ch_index < vti->num_aie_channels;
+ aie_ch_index++) {
+ ret = iio_read_channel_processed(vti->channel_aie[aie_ch_index], &val);
+ if (ret == IIO_VAL_FRACTIONAL) {
+ /* Convert raw value to temperature in millidegrees Celsius */
+ *temp = val * 1000;
+ *temp /= SYSMON_FRACTIONAL_DENOM;
+ } else if (ret == IIO_VAL_INT) {
+ *temp = val;
+ } else {
+ dev_err(vti->dev, "iio_read_channel_processed failed aie ch%d, ret = %d\n",
+ aie_ch_index, ret);
+ return ret;
+ }
+ if (*temp > max_temp)
+ max_temp = *temp;
+ }
+ *temp = max_temp;
+ return 0;
+}
+
static const struct thermal_zone_device_ops thermal_zone_ops = {
.get_temp = temperature_sensor_get_temp,
};
+static const struct thermal_zone_device_ops thermal_zone_ops_aie = {
+ .get_temp = temperature_sensor_get_temp_aie,
+};
+
+static void versal_thermal_iio_chan_release(struct versal_thermal_info *vti)
+{
+ int aie_ch_index;
+
+ if (!IS_ERR_OR_NULL(vti->channel))
+ iio_channel_release(vti->channel);
+ for (aie_ch_index = 0; aie_ch_index < vti->num_aie_channels; aie_ch_index++)
+ if (!IS_ERR_OR_NULL(vti->channel_aie[aie_ch_index]))
+ iio_channel_release(vti->channel_aie[aie_ch_index]);
+}
+
static int versal_thermal_probe(struct platform_device *pdev)
{
struct versal_thermal_info *vti;
+ struct device_node *sysmon_node;
+ struct device_node *child_node = NULL;
+ int aie_ch_index = 0;
+ int ret = 0;
+ u32 num_aie_channels = 0;
+ const char **aie_temp_chan_names;
+ const char *aie_temp_chan_name;
vti = devm_kzalloc(&pdev->dev, sizeof(struct versal_thermal_info), GFP_KERNEL);
if (!vti)
return -ENOMEM;
- vti->channel = devm_iio_channel_get(&pdev->dev, SYSMON_TEMP_CH_NAME);
- if (IS_ERR(vti->channel))
- return dev_err_probe(&pdev->dev, PTR_ERR(vti->channel),
- "IIO channel not found\n");
-
vti->dev = &pdev->dev;
+ vti->channel = iio_channel_get(NULL, SYSMON_TEMP_CH_NAME);
+ if (IS_ERR(vti->channel)) {
+ vti->num_aie_channels = 0;
+ versal_thermal_iio_chan_release(vti);
+ return dev_err_probe(&pdev->dev, PTR_ERR(vti->channel),
+ "IIO channel %s not found\n",
+ SYSMON_TEMP_CH_NAME);
+ }
+
vti->tzd = devm_thermal_of_zone_register(&pdev->dev, 0, vti, &thermal_zone_ops);
if (IS_ERR(vti->tzd))
return dev_err_probe(&pdev->dev, PTR_ERR(vti->tzd),
"Thermal zone sensor register failed\n");
- return devm_thermal_add_hwmon_sysfs(&pdev->dev, vti->tzd);
+ ret = devm_thermal_add_hwmon_sysfs(&pdev->dev, vti->tzd);
+ if (ret)
+ return dev_err_probe(&pdev->dev, ret,
+ "Failed to add hwmon sysfs for sysmon temp\n");
+
+ sysmon_node = of_find_node_by_name(NULL, "sysmon");
+ if (sysmon_node) {
+ ret = of_property_read_u32(sysmon_node, "xlnx,numaiechannels",
+ &num_aie_channels);
+ if (ret < 0)
+ num_aie_channels = 0;
+ }
+
+ if (num_aie_channels > 0) {
+ aie_temp_chan_names = devm_kcalloc(&pdev->dev, num_aie_channels,
+ sizeof(*aie_temp_chan_names),
+ GFP_KERNEL);
+ if (!aie_temp_chan_names)
+ return -ENOMEM;
+
+ for_each_child_of_node(sysmon_node, child_node) {
+ if (of_property_present(child_node, "xlnx,aie-temp")) {
+ ret = of_property_read_string(child_node, "xlnx,name",
+ &aie_temp_chan_name);
+ if (ret < 0) {
+ of_node_put(child_node);
+ return ret;
+ }
+ aie_temp_chan_names[aie_ch_index] = aie_temp_chan_name;
+ aie_ch_index++;
+ }
+ }
+
+ /* Allocate memory for the dynamic aie temperature channels */
+ vti->channel_aie = devm_kcalloc(&pdev->dev, num_aie_channels,
+ sizeof(*vti->channel_aie), GFP_KERNEL);
+ if (!vti->channel_aie)
+ return -ENOMEM;
+
+ for (aie_ch_index = 0; aie_ch_index < num_aie_channels; aie_ch_index++) {
+ vti->channel_aie[aie_ch_index] =
+ iio_channel_get(NULL, aie_temp_chan_names[aie_ch_index]);
+ if (IS_ERR(vti->channel_aie[aie_ch_index])) {
+ vti->num_aie_channels = aie_ch_index + 1;
+ versal_thermal_iio_chan_release(vti);
+ return dev_err_probe(&pdev->dev,
+ PTR_ERR(vti->channel_aie[aie_ch_index]),
+ "IIO AIE TEMP channel %s not found\n",
+ aie_temp_chan_names[aie_ch_index]);
+ }
+ }
+
+ vti->tzd_aie = devm_thermal_of_zone_register(&pdev->dev, 1, vti,
+ &thermal_zone_ops_aie);
+ if (IS_ERR(vti->tzd_aie))
+ return dev_err_probe(&pdev->dev, PTR_ERR(vti->tzd_aie),
+ "Failed to register thermal zone aie temp\n");
+
+ ret = devm_thermal_add_hwmon_sysfs(&pdev->dev, vti->tzd_aie);
+ if (ret)
+ return dev_err_probe(&pdev->dev, ret,
+ "Failed to add hwmon sysfs for aie temp\n");
+ }
+ vti->num_aie_channels = num_aie_channels;
+ platform_set_drvdata(pdev, vti);
+ return 0;
+}
+
+static void versal_thermal_remove(struct platform_device *pdev)
+{
+ struct versal_thermal_info *vti = platform_get_drvdata(pdev);
+
+ versal_thermal_iio_chan_release(vti);
}
static const struct of_device_id versal_thermal_of_match[] = {
@@ -78,6 +211,7 @@ static struct platform_driver versal_thermal_driver = {
.of_match_table = versal_thermal_of_match,
},
.probe = versal_thermal_probe,
+ .remove = versal_thermal_remove,
};
module_platform_driver(versal_thermal_driver);
--
2.43.0
Powered by blists - more mailing lists