[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4007710b-9e0c-499e-bbf7-246133ca9f21@oss.qualcomm.com>
Date: Fri, 5 Sep 2025 11:19:21 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Pavan Kondeti <pavan.kondeti@....qualcomm.com>,
hrishabh.rajput@....qualcomm.com
Cc: Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Guenter Roeck
<linux@...ck-us.net>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley
<conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] watchdog: Add driver for Gunyah Watchdog
On 9/4/25 7:11 PM, Pavan Kondeti wrote:
> On Wed, Sep 03, 2025 at 07:34:00PM +0000, Hrishabh Rajput via B4 Relay wrote:
>> +static int gunyah_wdt_call(unsigned long func_id, unsigned long arg1,
>> + unsigned long arg2, struct arm_smccc_res *res)
>> +{
>> + arm_smccc_1_1_smc(func_id, arg1, arg2, res);
>> + return gunyah_error_remap(res->a0);
>> +}
>> +
>> +static int gunyah_wdt_start(struct watchdog_device *wdd)
>> +{
>> + struct arm_smccc_res res;
>> + unsigned int timeout_ms;
>> + unsigned int pretimeout_ms;
>> + int ret;
>> +
>> + ret = gunyah_wdt_call(GUNYAH_WDT_CONTROL, WDT_CTRL_DISABLE, 0, &res);
>> + if (ret)
>> + return ret;
>
> When I ran a simple echo test, it failed here on SM8650 with -EINVAL. May be Gunyah
> does not allow disabling watchdog when it is not enabled in the first
> place. May be something you can check if this is a difference between
> 8750 vs 8650.
Hm, makes one wonder if the opposite (won't enable when already enabled)
is true..
Konrad
Powered by blists - more mailing lists