linux-kernel - Re: [PATCH v2] kconfig: Add transitional symbol attribute for migration support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bf12be7-7fd5-41e2-a0a2-da82903d0ccd@oracle.com>
Date: Fri, 5 Sep 2025 11:41:18 +0200
From: Vegard Nossum <vegard.nossum@...cle.com>
To: Kees Cook <kees@...nel.org>
Cc: Nathan Chancellor <nathan@...nel.org>,
        Nicolas Schier <nicolas.schier@...ux.dev>,
        Jonathan Corbet <corbet@....net>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Randy Dunlap
 <rdunlap@...radead.org>, Arnd Bergmann <arnd@...db.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-kbuild@...r.kernel.org, linux-doc@...r.kernel.org,
        Miguel Ojeda <ojeda@...nel.org>,
        Stephen Brennan <stephen.s.brennan@...cle.com>,
        Marco Bonelli <marco@...eim.net>, Petr Vorel <pvorel@...e.cz>,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] kconfig: Add transitional symbol attribute for
 migration support


On 04/09/2025 19:10, Vegard Nossum wrote:
> On 04/09/2025 19:03, Vegard Nossum wrote:
>> @@ -214,6 +214,11 @@ static void sym_calc_visibility(struct symbol *sym)
>>          struct property *prop;
>>          tristate tri;
>>
>> +       if (sym->flags & SYMBOL_HIDDEN) {
>> +               sym->visible = yes;
> 
> ...I just saw the irony here after having already pressed "Send".
> 
> Let me explain:
> 
> SYMBOL_HIDDEN is your new flag that indicates that somebody used
> "transitional" on the config entry.
> 
> sym->visible is tristate value that gives you the condition for whether
> a symbol can take on a value -- y/m means the option is visible to the
> user (hence the name) and thus eligible to have a value assigned to it.

Another small clarification: Replace "is visible to the user" by "can be
set by .config".

Actual user visibility is controlled by menu_is_visible(), not
sym->visible, so my patch still doesn't show transitional symbols to the
user in menuconfig. AFAICT, menu_is_visible() is completely independent
of sym->visible.

I tested menuconfig/mconf and oldconfig/conf --oldconfig with scripts/
kconfig/tests/transitional/Kconfig and my patch and it looks correct
(only the new options are displayed).


Vegard