[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4bbaefae-1d10-461a-a7a2-61a052241028@ti.com>
Date: Fri, 5 Sep 2025 15:27:17 +0530
From: Harikrishna Shenoy <h-shenoy@...com>
To: Rob Herring <robh@...nel.org>
CC: <andrzej.hajda@...el.com>, <neil.armstrong@...aro.org>, <rfoss@...nel.org>,
<Laurent.pinchart@...asonboard.com>, <jonas@...boo.se>,
<jernej.skrabec@...il.com>, <airlied@...il.com>, <simona@...ll.ch>,
<maarten.lankhorst@...ux.intel.com>, <mripard@...nel.org>,
<tzimmermann@...e.de>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
<sjakhade@...ence.com>, <yamonkar@...ence.com>,
<dri-devel@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <devarsht@...com>, <u-kumar1@...com>,
<s-jain1@...com>
Subject: Re: [PATCH v2] dt-bindings: drm/bridge: MHDP8546 bridge binding
changes for DSC
On 9/4/25 03:33, Rob Herring wrote:
> On Wed, Sep 03, 2025 at 04:43:57PM +0530, Harikrishna Shenoy wrote:
>> From: Swapnil Jakhade <sjakhade@...ence.com>
>>
>> Add binding changes for DSC(Display Stream Compression) in the MHDP8546
>> DPI/DP bridge.
>>
>> Signed-off-by: Swapnil Jakhade <sjakhade@...ence.com>
>> Signed-off-by: Harikrishna Shenoy <h-shenoy@...com>
>> ---
>> .../bindings/display/bridge/cdns,mhdp8546.yaml | 11 +++++++----
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
>> index c2b369456e4e..6e749c002669 100644
>> --- a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
>> +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
>> @@ -27,6 +27,8 @@ properties:
>> Register block for DSS_EDP0_INTG_CFG_VP registers in case of TI J7 SoCs.
>> - description:
>> Register block of mhdptx sapb registers.
>> + - description:
>> + Register block for mhdptx DSC encoder registers.
>>
>> reg-names:
>> minItems: 1
>> @@ -34,6 +36,7 @@ properties:
>> - const: mhdptx
>> - const: j721e-intg
>> - const: mhdptx-sapb
>> + - const: mhdptx-dsc
> 'mhdptx' is redundant. Don't continue that pattern. Just 'dsc'.
so sequence should be mhdptx, j721e-intg, mhdptx-sapb, dsc?
>
>>
>> clocks:
>> maxItems: 1
>> @@ -100,18 +103,18 @@ allOf:
>> properties:
>> reg:
>> minItems: 2
>> - maxItems: 3
>> + maxItems: 4
>> reg-names:
>> minItems: 2
>> - maxItems: 3
>> + maxItems: 4
>> else:
>> properties:
>> reg:
>> minItems: 1
>> - maxItems: 2
>> + maxItems: 3
>> reg-names:
>> minItems: 1
>> - maxItems: 2
>> + maxItems: 3
> Have you tested this works? While it might work for TI with the
> j721e-intg registers in the middle, it won't work for platforms without
> them. You're going to have to have 2 lists of reg-names.
>
> Rob
>
I will add two lists one with and one without j721e-integ in the 'if'
condtional
Powered by blists - more mailing lists