linux-kernel - RE: [PATCH v2 1/2] pinctrl: renesas: rzg2l: Fix OEN resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB11346E5ED379B786B111791088603A@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Fri, 5 Sep 2025 09:58:39 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: geert <geert@...ux-m68k.org>, biju.das.au <biju.das.au@...il.com>
CC: Linus Walleij <linus.walleij@...aro.org>, Prabhakar Mahadev Lad
	<prabhakar.mahadev-lad.rj@...renesas.com>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/2] pinctrl: renesas: rzg2l: Fix OEN resume

Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: 05 September 2025 10:40
> Subject: Re: [PATCH v2 1/2] pinctrl: renesas: rzg2l: Fix OEN resume
> 
> Hi Biju,
> 
> On Sun, 17 Aug 2025 at 16:30, Biju <biju.das.au@...il.com> wrote:
> > From: Biju Das <biju.das.jz@...renesas.com>
> >
> > The write to PFC_OEN register is controlled by the write protect
> > register (PWPR). Currently OEN register write in resume() is done
> > without enabling the write access in PWPR leading to incorrect operation.
> >
> > Fixes: cd39805be85b ("pinctrl: renesas: rzg2l: Unify OEN handling
> > across RZ/{G2L,V2H,V2N}")
> > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> 
> Thanks for your patch!
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be> i.e. will queue in renesas-pinctrl for v6.18.
> 
> > --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> > +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> 
> > @@ -3174,7 +3176,15 @@ static int rzg2l_pinctrl_resume_noirq(struct device *dev)
> >         }
> >
> >         writeb(cache->qspi, pctrl->base + QSPI);
> > +       spin_lock_irqsave(&pctrl->lock, flags);
> > +       if (pctrl->data->hwcfg->oen_pwpr_lock) {
> > +               pwpr = readb(pctrl->base + regs->pwpr);
> > +               writeb(pwpr | PWPR_REGWE_B, pctrl->base + regs->pwpr);
> > +       }
> >         writeb(cache->oen, pctrl->base +
> > pctrl->data->hwcfg->regs.oen);
> > +       if (pctrl->data->hwcfg->oen_pwpr_lock)
> > +               writeb(pwpr & ~PWPR_REGWE_B, pctrl->base + regs->pwpr);
> > +       spin_unlock_irqrestore(&pctrl->lock, flags);
> >         for (u8 i = 0; i < 2; i++) {
> >                 if (regs->sd_ch)
> >                         writeb(cache->sd_ch[i], pctrl->base +
> > SD_CH(regs->sd_ch, i));
> 
> Would you mind if I moved the spin_*lock* calls inside the if-statements while applying?

It is ok for me.

Thanks,
Biju