linux-kernel - Re: [PATCH v2 1/2] media: dt-bindings: i2c: add Himax HM1246 image sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLq0jJtdaxIpN9CT@valkosipuli.retiisi.eu>
Date: Fri, 5 Sep 2025 12:59:40 +0300
From: Sakari Ailus <sakari.ailus@....fi>
To: Matthias Fend <matthias.fend@...end.at>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	bsp-development.geo@...ca-geosystems.com
Subject: Re: [PATCH v2 1/2] media: dt-bindings: i2c: add Himax HM1246 image
 sensor

Hi Matthias,

Thanks for the set.

On Mon, May 26, 2025 at 08:59:27AM +0200, Matthias Fend wrote:
> Add YAML device tree binding for Himax HM1246 image sensor.
> 
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
> Signed-off-by: Matthias Fend <matthias.fend@...end.at>
> ---
>  .../bindings/media/i2c/himax,hm1246.yaml           | 111 +++++++++++++++++++++
>  1 file changed, 111 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/himax,hm1246.yaml b/Documentation/devicetree/bindings/media/i2c/himax,hm1246.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..8a67de7e3ffcaa9f1acfe443b1e36fffb79dbacf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/himax,hm1246.yaml
> @@ -0,0 +1,111 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2025 Matthias Fend <matthias.fend@...end.at>
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/himax,hm1246.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Himax HM1246-AWD 1/3.7-Inch megapixel SoC image sensor
> +
> +maintainers:
> +  - Matthias Fend <matthias.fend@...end.at>
> +
> +description:
> +  The Himax HM1246-AWD is a 1/3.7-Inch CMOS image sensor SoC with an active
> +  array size of 1296 x 976. It is programmable through an I2C interface and
> +  connected via parallel bus.
> +
> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> +  compatible:
> +    const: himax,hm1246
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    description: Input reference clock (6 - 27 MHz)
> +    maxItems: 1
> +
> +  reset-gpios:
> +    description: Active low XSHUTDOWN pin
> +    maxItems: 1
> +
> +  avdd-supply:
> +    description: Power for analog circuit (3.0 - 3.6 V)
> +
> +  iovdd-supply:
> +    description: Power for I/O circuit (1.7 - 3.6 V)
> +
> +  dvdd-supply:
> +    description: Power for digital circuit (1.5 / 1.8 V)
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +    description: Parallel video output port
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          bus-type:
> +            const: 5

Does the device also support e.g. Bt.656? If not, you can drop this.

If the rest of the parallel interface parameter properties aren't
mandatory, what are their default values?

> +
> +        required:
> +          - bus-type
> +
> +    required:
> +      - endpoint
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - avdd-supply
> +  - iovdd-supply
> +  - dvdd-supply
> +  - port
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/media/video-interfaces.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        sensor@24 {
> +            compatible =  "himax,hm1246";
> +            reg = <0x24>;
> +
> +            clocks = <&hm1246_clk>;
> +
> +            reset-gpios = <&gpio0 0 GPIO_ACTIVE_LOW>;
> +
> +            avdd-supply = <&hm1246_avdd>;
> +            iovdd-supply = <&hm1246_iovdd>;
> +            dvdd-supply = <&hm1246_dvdd>;
> +
> +            orientation = <2>;

It'd be nice to add macros for these in
include/dt-bindings/media/video-interfaces.h .

> +            rotation = <0>;
> +
> +            port {
> +                endpoint {
> +                    remote-endpoint = <&isp_par_in>;
> +                    bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> +                    bus-width = <10>;
> +                    hsync-active = <1>; /* active high */
> +                    vsync-active = <1>; /* active high */
> +                    pclk-sample = <1>; /* sample on rising edge */
> +                };
> +            };
> +        };
> +    };
> 

-- 
Regards,

Sakari Ailus