linux-kernel - Re: [PATCH net-next v3] rds: ib: Remove unused extern definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2AEDD90C-A0B6-4207-9C93-8C618AFB8EB7@oracle.com>
Date: Fri, 5 Sep 2025 10:05:49 +0000
From: Haakon Bugge <haakon.bugge@...cle.com>
To: Allison Henderson <allison.henderson@...cle.com>
CC: "horms@...nel.org" <horms@...nel.org>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "rds-devel@....oracle.com" <rds-devel@....oracle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        OFED mailing list
	<linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v3] rds: ib: Remove unused extern definition



> On 5 Sep 2025, at 00:43, Allison Henderson <allison.henderson@...cle.com> wrote:
> 
> On Thu, 2025-09-04 at 17:01 +0200, Håkon Bugge wrote:
>> In the old days, RDS used FMR (Fast Memory Registration) to register
>> IB MRs to be used by RDMA. A newer and better verbs based
>> registration/de-registration method called FRWR (Fast Registration
>> Work Request) was added to RDS by commit 1659185fb4d0 ("RDS: IB:
>> Support Fastreg MR (FRMR) memory registration mode") in 2016.
>> 
>> Detection and enablement of FRWR was done in commit 2cb2912d6563
>> ("RDS: IB: add Fastreg MR (FRMR) detection support"). But said commit
>> added an extern bool prefer_frmr, which was not used by said commit -
>> nor used by later commits. Hence, remove it.
>> 
>> Signed-off-by: Håkon Bugge <haakon.bugge@...cle.com>
>> 
>> ---
> Hi Håkon,
> 
> Just one nit with the change log indentation here.  Version numbering is typically left-aligned, unless you meant to
> have a header of sorts to justify the level indentation.  Otherwise just bring the v2 -> v3: / v1 -> v2: lines flush
> left.
> 
> Content-wise this patch looks fine to me.  With the indent nit fixed, you can add my rvb:
> Reviewed-by: Allison Henderson <allison.henderson@...cle.com>
Hi Allison,


Will do. But, as you know, what comes after the "---" line gets stripped off when the patch is applied anyway.


Thxs, Håkon

> 
> Thank you!
> 
> Allison
> 
>> 
>> v2 -> v3:
>>      * As per Jakub's request, removed Cc: and Fixes: tags
>>      * Subject to net-next (instead of net)
>> 
>> v1 -> v2:
>>      * Added commit message
>>      * Added Cc: stable@...r.kernel.org
>> ---
>> net/rds/ib_mr.h | 1 -
>> 1 file changed, 1 deletion(-)
>> 
>> diff --git a/net/rds/ib_mr.h b/net/rds/ib_mr.h
>> index ea5e9aee4959e..5884de8c6f45b 100644
>> --- a/net/rds/ib_mr.h
>> +++ b/net/rds/ib_mr.h
>> @@ -108,7 +108,6 @@ struct rds_ib_mr_pool {
>> };
>> 
>> extern struct workqueue_struct *rds_ib_mr_wq;
>> -extern bool prefer_frmr;
>> 
>> struct rds_ib_mr_pool *rds_ib_create_mr_pool(struct rds_ib_device *rds_dev,
>>     int npages);