linux-kernel - Re: [PATCH v5 01/14] media: ti: j721e-csi2rx: Remove word size alignment on frame width

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3bb314a8-2ce0-4c54-bab0-e0af70bf22b9@ti.com>
Date: Fri, 5 Sep 2025 15:40:40 +0530
From: Yemike Abhilash Chandra <y-abhilashchandra@...com>
To: Rishikesh Donadkar <r-donadkar@...com>, <jai.luthra@...ux.dev>,
        <laurent.pinchart@...asonboard.com>, <mripard@...nel.org>
CC: <devarsht@...com>, <vaishnav.a@...com>, <s-jain1@...com>,
        <vigneshr@...com>, <mchehab@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <sakari.ailus@...ux.intel.com>, <hverkuil-cisco@...all.nl>,
        <tomi.valkeinen@...asonboard.com>, <jai.luthra@...asonboard.com>,
        <changhuang.liang@...rfivetech.com>, <jack.zhu@...rfivetech.com>,
        <linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v5 01/14] media: ti: j721e-csi2rx: Remove word size
 alignment on frame width

Hi Rishikesh,

Thanks for the patches.

On 25/08/25 19:55, Rishikesh Donadkar wrote:
> j721e-csi2rx driver has a limitation of frame width being a multiple
> word size. However, there is no such limitation imposed by the
> hardware [1].
> 
> Remove this limitation from the driver.
> 
> Link: https://www.ti.com/lit/pdf/spruj16
> Signed-off-by: Rishikesh Donadkar <r-donadkar@...com>
> ---

Reviewed-by: Yemike Abhilash Chandra <y-abhilashchandra@...com>

>   .../platform/ti/j721e-csi2rx/j721e-csi2rx.c     | 17 +++--------------
>   1 file changed, 3 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> index 3992f8b754b7..b3a27f4c3210 100644
> --- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> +++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> @@ -260,9 +260,6 @@ static void ti_csi2rx_fill_fmt(const struct ti_csi2rx_fmt *csi_fmt,
>   			     MAX_WIDTH_BYTES * 8 / csi_fmt->bpp);
>   	pix->height = clamp_t(unsigned int, pix->height, 1, MAX_HEIGHT_LINES);
>   
> -	/* Width should be a multiple of transfer word-size */
> -	pix->width = rounddown(pix->width, pixels_in_word);
> -
>   	v4l2_fmt->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
>   	pix->pixelformat = csi_fmt->fourcc;
>   	pix->bytesperline = pix->width * (csi_fmt->bpp / 8);
> @@ -360,23 +357,15 @@ static int ti_csi2rx_enum_framesizes(struct file *file, void *fh,
>   				     struct v4l2_frmsizeenum *fsize)
>   {
>   	const struct ti_csi2rx_fmt *fmt;
> -	unsigned int pixels_in_word;
>   
>   	fmt = find_format_by_fourcc(fsize->pixel_format);
>   	if (!fmt || fsize->index != 0)
>   		return -EINVAL;
>   
> -	/*
> -	 * Number of pixels in one PSI-L word. The transfer happens in multiples
> -	 * of PSI-L word sizes.
> -	 */
> -	pixels_in_word = PSIL_WORD_SIZE_BYTES * 8 / fmt->bpp;
> -
>   	fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE;
> -	fsize->stepwise.min_width = pixels_in_word;
> -	fsize->stepwise.max_width = rounddown(MAX_WIDTH_BYTES * 8 / fmt->bpp,
> -					      pixels_in_word);
> -	fsize->stepwise.step_width = pixels_in_word;
> +	fsize->stepwise.min_width = 1;
> +	fsize->stepwise.max_width = MAX_WIDTH_BYTES * 8 / fmt->bpp;
> +	fsize->stepwise.step_width = 1;
>   	fsize->stepwise.min_height = 1;
>   	fsize->stepwise.max_height = MAX_HEIGHT_LINES;
>   	fsize->stepwise.step_height = 1;