linux-kernel - Re: [PATCH v2 2/3] ASoC: qcom: q6apm-lpass-dais: Fix missing set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59775bbf-5e8d-4302-910f-94c7e1d5d9e3@oss.qualcomm.com>
Date: Fri, 5 Sep 2025 11:44:41 +0100
From: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
To: Mohammad Rafi Shaik <mohammad.rafi.shaik@....qualcomm.com>,
        Srinivas Kandagatla <srini@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>
Cc: linux-sound@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@....qualcomm.com,
        prasad.kumpatla@....qualcomm.com, ajay.nandam@....qualcomm.com
Subject: Re: [PATCH v2 2/3] ASoC: qcom: q6apm-lpass-dais: Fix missing set_fmt
 DAI op for I2S

On 9/5/25 11:40 AM, Mohammad Rafi Shaik wrote:
> The q6i2s_set_fmt() function was defined but never linked into the
> I2S DAI operations, resulting DAI format settings is being ignored
> during stream setup. This change fixes the issue by properly linking
> the .set_fmt handler within the DAI ops.
> 
> Fixes: 30ad723b93ade ("ASoC: qdsp6: audioreach: add q6apm lpass dai support")

Missing CC stable?

> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@....qualcomm.com>
> ---

other than that, LGTM,

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>

--srini

>  sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
> index 20974f10406b..528756f1332b 100644
> --- a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
> +++ b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
> @@ -262,6 +262,7 @@ static const struct snd_soc_dai_ops q6i2s_ops = {
>  	.shutdown	= q6apm_lpass_dai_shutdown,
>  	.set_channel_map  = q6dma_set_channel_map,
>  	.hw_params        = q6dma_hw_params,
> +	.set_fmt	= q6i2s_set_fmt,
>  };
>  
>  static const struct snd_soc_dai_ops q6hdmi_ops = {