linux-kernel - Re: [PATCH 2/2] ASoC: replace use of system_wq with system_percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54446af3-9ca5-4932-a3fd-e44185751dda@sirena.org.uk>
Date: Fri, 5 Sep 2025 11:54:47 +0100
From: Mark Brown <broonie@...nel.org>
To: Marco Crivellari <marco.crivellari@...e.com>
Cc: linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org,
	Tejun Heo <tj@...nel.org>, Lai Jiangshan <jiangshanlai@...il.com>,
	Frederic Weisbecker <frederic@...nel.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Michal Hocko <mhocko@...e.com>, Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH 2/2] ASoC: replace use of system_wq with system_percpu_wq

On Fri, Sep 05, 2025 at 11:10:16AM +0200, Marco Crivellari wrote:

> +++ b/sound/soc/codecs/aw88081.c
> @@ -779,7 +779,7 @@ static void aw88081_start(struct aw88081 *aw88081, bool sync_start)
>  	if (sync_start == AW88081_SYNC_START)
>  		aw88081_start_pa(aw88081);
>  	else
> -		queue_delayed_work(system_wq,
> +		queue_delayed_work(system_percpu_wq,
>  			&aw88081->start_work,
>  			AW88081_START_WORK_DELAY_MS);
>  }

I can't tell why you're putting all these onto the percpu workqeue, I
would be astonished if any of the users cared.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)