linux-kernel - Re: [PATCH] dt-bindings: i3c: renesas,i3c: Add RZ/V2H(P) and RZ/V2N support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLrFKb27MFPFhDHt@tom-desktop>
Date: Fri, 5 Sep 2025 13:10:33 +0200
From: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>
To: Prabhakar <prabhakar.csengg@...il.com>
Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Frank Li <Frank.Li@....com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Magnus Damm <magnus.damm@...il.com>, linux-i3c@...ts.infradead.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org,
	Biju Das <biju.das.jz@...renesas.com>,
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH] dt-bindings: i3c: renesas,i3c: Add RZ/V2H(P) and RZ/V2N
 support

Hi Prabhakar,
Thank you for your patch!

On Thu, Sep 04, 2025 at 05:03:05PM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> 
> Add device tree binding support for the I3C Bus Interface on Renesas
> RZ/V2H(P) and RZ/V2N SoCs. The I3C IP on these SoCs is identical to
> that found on the RZ/G3E SoC.
> 
> Add new compatible strings "renesas,r9a09g056-i3c" for RZ/V2N and
> "renesas,r9a09g057-i3c" for RZ/V2H(P). Both variants use
> "renesas,r9a09g047-i3c" as a fallback compatible to indicate hardware
> compatibility with the RZ/G3E implementation.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> ---
>  .../devicetree/bindings/i3c/renesas,i3c.yaml     | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i3c/renesas,i3c.yaml b/Documentation/devicetree/bindings/i3c/renesas,i3c.yaml
> index fe2e9633c46f..e41ba3ba4b58 100644
> --- a/Documentation/devicetree/bindings/i3c/renesas,i3c.yaml
> +++ b/Documentation/devicetree/bindings/i3c/renesas,i3c.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/i3c/renesas,i3c.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Renesas RZ/G3S and RZ/G3E I3C Bus Interface
> +title: Renesas RZ/G3S, RZ/G3E, RZ/V2H(P) and RZ/V2N I3C Bus Interface
>  
>  maintainers:
>    - Wolfram Sang <wsa+renesas@...g-engineering.com>
> @@ -12,10 +12,16 @@ maintainers:
>  
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - renesas,r9a08g045-i3c # RZ/G3S
> -          - renesas,r9a09g047-i3c # RZ/G3E
> +    oneOf:
> +      - items:
> +          - enum:
> +              - renesas,r9a08g045-i3c # RZ/G3S
> +              - renesas,r9a09g047-i3c # RZ/G3E
> +      - items:
> +          - enum:
> +              - renesas,r9a09g056-i3c # RZ/V2N
> +              - renesas,r9a09g057-i3c # RZ/V2H(P)
> +          - const: renesas,r9a09g047-i3c
>  
>    reg:
>      maxItems: 1
> -- 
> 2.51.0
> 

Looks good to me.

Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>


Kind Regards,
Tommaso