linux-kernel - Re: [PATCH v7] arm64: dts: qcom: x1e78100-t14s-oled: Add eDP panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACr-zFCjrQAM0W9NnWJTwGYc=MnR8ODawW-DK+LJjRJYJznaEQ@mail.gmail.com>
Date: Fri, 5 Sep 2025 01:14:57 +0100
From: Christopher Obbard <christopher.obbard@...aro.org>
To: Bjorn Andersson <andersson@...nel.org>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, Johan Hovold <johan@...nel.org>, 
	Rui Miguel Silva <rui.silva@...aro.org>, Abel Vesa <abel.vesa@...aro.org>, devicetree@...r.kernel.org, 
	Konrad Dybcio <konrad.dybcio@....qualcomm.com>, Konrad Dybcio <quic_kdybcio@...cinc.com>, 
	Douglas Anderson <dianders@...omium.org>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Jessica Zhang <quic_jesszhan@...cinc.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, 
	Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, 
	Aleksandrs Vinarskis <alex.vinarskis@...il.com>, Sibi Sankar <quic_sibis@...cinc.com>, 
	Rajendra Nayak <quic_rjendra@...cinc.com>, Xilin Wu <wuxilin123@...il.com>, 
	Jens Glathe <jens.glathe@...schoolsolutions.biz>, Srinivas Kandagatla <srini@...nel.org>
Subject: Re: [PATCH v7] arm64: dts: qcom: x1e78100-t14s-oled: Add eDP panel

Hi Bjorn,

Any feedback on this patch ?
I'd love it if you could consider it for inclusion in your next qcom
pull request.
Or if there is any issues, I can send another version quickly. Let me know !

Cheers!

Chris


On Thu, 14 Aug 2025 at 21:16, Christopher Obbard
<christopher.obbard@...aro.org> wrote:
>
> Add the Samsung ATNA40YK20 eDP panel to the device tree for the
> Snapdragon T14s OLED model.
>
> Signed-off-by: Christopher Obbard <christopher.obbard@...aro.org>
> ---
> The Snapdragon Lenovo T14s Gen6 can be bought with a number of different
> panels. This patch series adds support for the OLED model which has a
> Samsung ATNA40YK20 panel.
>
> This series depends on [0] which adds the edp_hpd_active pinctrl node.
>
> With this patch series the backlight of the OLED eDP panel does not
> illuminate since the brightness is incorrectly read from the eDP panel
> as (to be clear this is not a regression). This is fixed in [1].
>
> [0]: https://lore.kernel.org/linux-arm-msm/20250814-x1e80100-add-edp-hpd-v1-0-a52804db53f6@linaro.org/
> [1]: https://lore.kernel.org/all/20250814-topic-x1e80100-t14s-oled-dp-brightness-v7-1-b3d7b4dfe8c5@linaro.org/
> ---
> Changes in v7:
> - Remove patch adding edp_hpd_active since now handled in Stephan's series [0].
> - Properly add OLED brighness patch as dependency [1].
> - Link to v6: https://lore.kernel.org/r/20250731-wip-obbardc-qcom-t14s-oled-panel-v6-0-4782074104d1@linaro.org
>
> Changes in v6:
> - Squash patches adding "edp_hpd_active" node & its user (Johan).
> - Sort new pinctrl node correctly by name (Johan).
> - Use correct function "edp0_hot" instead of "edp_hot" (Johan).
> - Drop review tags.
> - Link to v5: https://lore.kernel.org/r/20250402-wip-obbardc-qcom-t14s-oled-panel-v5-0-ff33f4d0020f@linaro.org
>
> Changes in v5:
> - Move edp_hpd_active from T14s DTS into SoC DTSI (Dmitry).
> - Link to v4: https://lore.kernel.org/r/20250402-wip-obbardc-qcom-t14s-oled-panel-v4-0-41ba3f3739d0@linaro.org
>
> Changes in v4:
> - Rework HPD GPIO into eDP device rather than panel (Johan).
> - Drop review tags for HPD GPIO patch.
> - Link to v3: https://lore.kernel.org/r/20250327-wip-obbardc-qcom-t14s-oled-panel-v3-0-45d5f2747398@linaro.org
>
> Changes in v3:
> - Added review trailers from v2.
> - Dropped dt-binding documentation patch (applied by Douglas Anderson into
>   drm-misc-next).
> - Dropped eDP maximum brightness patch (will be sent in separate
>   series).
> - Removed duplicate nodes in T14s OLED device tree.
> - Reworked WIP comments from commit messages.
> - Link to v2: https://lore.kernel.org/r/20250325-wip-obbardc-qcom-t14s-oled-panel-v2-0-e9bc7c9d30cc@linaro.org
>
> Changes in v2:
> - Use the existing atna33xc20 driver rather than panel-edp.
> - Add eDP panel into OLED devicetree.
> - Add patch to read the correct maximum brightness from the eDP panel.
> - Link to v1: https://lore.kernel.org/r/20250320-wip-obbardc-qcom-t14s-oled-panel-v1-1-05bc4bdcd82a@linaro.org
> ---
>  arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dts
> index be65fafafa736a0401a5872c40f69cb20cfbbd90..d524afa12d19b2a6f22a24b9bed6b6b40248375f 100644
> --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dts
> @@ -10,3 +10,11 @@ / {
>         compatible = "lenovo,thinkpad-t14s-oled", "lenovo,thinkpad-t14s",
>                      "qcom,x1e78100", "qcom,x1e80100";
>  };
> +
> +&panel {
> +       compatible = "samsung,atna40yk20", "samsung,atna33xc20";
> +       enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>;
> +
> +       pinctrl-0 = <&edp_bl_en>;
> +       pinctrl-names = "default";
> +};
>
> ---
> base-commit: 33a21dab19b31540dfeb06dde02e55129a10aec4
> change-id: 20250320-wip-obbardc-qcom-t14s-oled-panel-b74fed21d600
> prerequisite-message-id: <20250814-x1e80100-add-edp-hpd-v1-0-a52804db53f6@...aro.org>
> prerequisite-patch-id: 658fd45e0cb953e3c667a30f2cf78cfd3582d552
> prerequisite-patch-id: fc665d8cdd099464e6fa4401489fde70b65bed30
> prerequisite-patch-id: 13ff38b40f2dcb283be82485e88ca4efc249599b
> prerequisite-patch-id: 7d02075f074ad8f32eeaf5ee8833d0c6a230cea8
> prerequisite-patch-id: 380fed6c07ca1ecdb73768054454e47c984d00e9
> prerequisite-patch-id: 1f8b24fc983fa23abc97512e15626394ce760ffe
> prerequisite-patch-id: 7d29e2fee2b19cf2d12d54cca052b1c1fb808c9d
> prerequisite-patch-id: c5bf1706ecf4df7782707bbf0d18a0568842b562
> prerequisite-patch-id: 34889448fd92cdc916e7e19eac8446710d2a646a
> prerequisite-message-id: <20250814-topic-x1e80100-t14s-oled-dp-brightness-v7-1-b3d7b4dfe8c5@...aro.org>
> prerequisite-patch-id: ceed93f46ae27c7980c5b57022068daaad8dc8c9
>
> Best regards,
> --
> Christopher Obbard <christopher.obbard@...aro.org>
>